Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Issue 2730003002: [M57] Enable ARC kiosk mode always when ARC is available (Closed)

Created:
3 years, 9 months ago by elijahtaylor1
Modified:
3 years, 9 months ago
Reviewers:
hidehiko, achuithb
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, alemate+watch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, achuith+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[M57] Enable ARC kiosk mode always when ARC is available This removes --enable-arc-kiosk flag and instead uses --arc-available to make this decision. BUG=697741 TEST=./unit_tests --gtest_filter="ChromeArcUtilTest.*" TEST=./components_unittests --gtest_filter="ArcUtilTest.*" (cherry-picked from 67e99111e67ac5aeae011a14154e054160bf98c4) R=achuith@chromium.org, hidehiko@chromium.org Review-Url: https://codereview.chromium.org/2730003002 . Cr-Commit-Position: refs/branch-heads/2987@{#789} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/92f2f530433fba0aa27d87690d517325d900f11e

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
elijahtaylor1
I'm waiting on merge approval on the bug, but since this was a very manual ...
3 years, 9 months ago (2017-03-03 02:18:52 UTC) #3
hidehiko
lgtm
3 years, 9 months ago (2017-03-03 04:47:03 UTC) #4
achuithb
lgtm
3 years, 9 months ago (2017-03-03 10:57:43 UTC) #5
achuithb
Another thing to consider is to just merge arc_bridge_service.cc
3 years, 9 months ago (2017-03-03 11:00:17 UTC) #10
elijahtaylor1
3 years, 9 months ago (2017-03-07 21:00:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
92f2f530433fba0aa27d87690d517325d900f11e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698