Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2729943003: Recover from bad supertypes. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update status files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -139 lines) Patch
M pkg/front_end/lib/src/fasta/builder/dynamic_type_builder.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/type_builder.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/type_declaration_builder.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/type_variable_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 6 chunks +10 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart View 2 chunks +9 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 4 chunks +9 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 2 chunks +10 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart View 5 chunks +12 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_mixin_application_builder.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart View 2 chunks +16 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart View 8 chunks +13 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 3 chunks +15 lines, -14 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_type_builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_type_variable_builder.dart View 4 chunks +8 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_class_builder.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 4 chunks +0 lines, -15 lines 0 comments Download
M tests/language/language_kernel.status View 1 7 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
https://codereview.chromium.org/2729943003/diff/1/pkg/front_end/test/fasta/compile.status File pkg/front_end/test/fasta/compile.status (right): https://codereview.chromium.org/2729943003/diff/1/pkg/front_end/test/fasta/compile.status#newcode13 pkg/front_end/test/fasta/compile.status:13: type_variable_as_super: Fail This test is still failing because we ...
3 years, 9 months ago (2017-03-03 13:28:05 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2729943003/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart File pkg/front_end/lib/src/fasta/kernel/kernel_target.dart (right): https://codereview.chromium.org/2729943003/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart#newcode355 pkg/front_end/lib/src/fasta/kernel/kernel_target.dart:355: loader.builders.forEach((Uri uri, LibraryBuilder library) { Why this change? ...
3 years, 9 months ago (2017-03-03 13:43:08 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/2729943003/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart File pkg/front_end/lib/src/fasta/kernel/kernel_target.dart (right): https://codereview.chromium.org/2729943003/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart#newcode363 pkg/front_end/lib/src/fasta/kernel/kernel_target.dart:363: cls.mixedInType = builder.mixedInType.buildSupertype(library); I need access ...
3 years, 9 months ago (2017-03-03 13:52:53 UTC) #4
ahe
3 years, 9 months ago (2017-03-03 14:06:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3873b0fc83d2c598e966216925f816ccd81a58e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698