Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: pkg/front_end/lib/src/fasta/source/source_class_builder.dart

Issue 2729943003: Recover from bad supertypes. (Closed)
Patch Set: Update status files. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/source_class_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/source/source_class_builder.dart b/pkg/front_end/lib/src/fasta/source/source_class_builder.dart
index 3c2abf2543f03fae445324fbbbe4d995d7930d4d..017534bf16aaaadf96d3167b351b6abf180b6006 100644
--- a/pkg/front_end/lib/src/fasta/source/source_class_builder.dart
+++ b/pkg/front_end/lib/src/fasta/source/source_class_builder.dart
@@ -85,9 +85,9 @@ class SourceClassBuilder extends KernelClassBuilder {
if (builder is KernelFieldBuilder) {
// TODO(ahe): It would be nice to have a common interface for the build
// method to avoid duplicating these two cases.
- cls.addMember(builder.build(library.library));
+ cls.addMember(builder.build(library));
} else if (builder is KernelFunctionBuilder) {
- cls.addMember(builder.build(library.library));
+ cls.addMember(builder.build(library));
} else {
internalError("Unhandled builder: ${builder.runtimeType}");
}
@@ -99,14 +99,14 @@ class SourceClassBuilder extends KernelClassBuilder {
builder = builder.next;
} while (builder != null);
});
- cls.supertype = supertype?.buildSupertype();
- cls.mixedInType = mixedInType?.buildSupertype();
+ cls.supertype = supertype?.buildSupertype(library);
+ cls.mixedInType = mixedInType?.buildSupertype(library);
// TODO(ahe): If `cls.supertype` is null, and this isn't Object, report a
// compile-time error.
cls.isAbstract = isAbstract;
if (interfaces != null) {
for (KernelTypeBuilder interface in interfaces) {
- Supertype supertype = interface.buildSupertype();
+ Supertype supertype = interface.buildSupertype(library);
if (supertype != null) {
// TODO(ahe): Report an error if supertype is null.
cls.implementedTypes.add(supertype);
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_type_variable_builder.dart ('k') | pkg/front_end/test/fasta/compile.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698