Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2729943002: [WASM] Implement remaining F32x4 operations for ARM. (Closed)

Created:
3 years, 9 months ago by bbudge
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[WASM] Implement remaining F32x4 operations for ARM. - Implements Float32x4 Mul, Min, Max for ARM. - Implements Float32x4 relational ops for ARM. - Implements reciprocal, reciprocal square root estimate/refinement ops for ARM. - Reorganizes tests to eliminate need for specialized float ref fns in tests. - Rephrases Gt, Ge in terms of Lt, Le, and eliminates the redundant machine operators. - Renames test-run-wasm-simd test names to match instructions. LOG=N BUG=v8:6020 Review-Url: https://codereview.chromium.org/2729943002 Cr-Commit-Position: refs/heads/master@{#43658} Committed: https://chromium.googlesource.com/v8/v8/+/78382d72729cf68143a2b83f784e5910ec331803

Patch Set 1 #

Patch Set 2 : All FP operations except MinNum, MaxNum, Div, Sqrt. #

Total comments: 2

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -432 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 9 chunks +79 lines, -36 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 4 chunks +21 lines, -12 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 4 chunks +21 lines, -12 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 2 1 chunk +91 lines, -82 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 13 chunks +78 lines, -60 lines 0 comments Download
M src/compiler/machine-operator.h View 1 2 7 chunks +2 lines, -14 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 2 4 chunks +2 lines, -14 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 8 chunks +66 lines, -63 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/wasm/wasm-opcodes.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 2 17 chunks +177 lines, -137 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
bbudge
Martyn for ARM part, Brad for WASM / Turbofan
3 years, 9 months ago (2017-03-03 22:33:51 UTC) #7
bbudge
+ Benedikt for src/compiler
3 years, 9 months ago (2017-03-03 22:34:49 UTC) #9
bbudge
+ Aseem FYI
3 years, 9 months ago (2017-03-03 22:40:28 UTC) #11
Benedikt Meurer
Nice cleanup. Thanks. LGTM
3 years, 9 months ago (2017-03-04 18:02:12 UTC) #12
martyn.capewell
lgtm
3 years, 9 months ago (2017-03-07 18:23:16 UTC) #13
bbudge
-Brad +Mircea for wasm part
3 years, 9 months ago (2017-03-07 21:05:31 UTC) #15
Mircea Trofin
lgtm https://codereview.chromium.org/2729943002/diff/20001/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/2729943002/diff/20001/src/compiler/wasm-compiler.cc#newcode3627 src/compiler/wasm-compiler.cc:3627: case wasm::kExprI8x16GeU: Do you think we could do ...
3 years, 9 months ago (2017-03-07 22:09:30 UTC) #16
bbudge
https://codereview.chromium.org/2729943002/diff/20001/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/2729943002/diff/20001/src/compiler/wasm-compiler.cc#newcode3627 src/compiler/wasm-compiler.cc:3627: case wasm::kExprI8x16GeU: On 2017/03/07 22:09:30, Mircea Trofin wrote: > ...
3 years, 9 months ago (2017-03-07 23:35:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729943002/40001
3 years, 9 months ago (2017-03-07 23:35:37 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 00:01:44 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/78382d72729cf68143a2b83f784e5910ec3...

Powered by Google App Engine
This is Rietveld 408576698