UMA metrics for counting different ways of scrolling by keyboard.

UMA metrics for counting different ways of scrolling by keyboard.

TBR=mkwst@chromium.org
BUG=697611
TEST=LayoutTests/fast/events/keyboard-scroll-use-count.html

Review-Url: https://codereview.chromium.org/2729923002
Cr-Commit-Position: refs/heads/master@{#454619}
Committed: https://chromium.googlesource.com/chromium/src/+/200362b9d0f8bb3748364f8d4938ec6333cf47ab

[sahel, 2017-03-02 16:42:17]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 16:42:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 16:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 16:44:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[sahel, 2017-03-02 16:58:33]

Patchset #1 (id:1) has been deleted

[sahel, 2017-03-02 16:58:38]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 16:59:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 20:58:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 20:58:20]

Dry run: This issue passed the CQ dry run.

[sahel, 2017-03-02 21:03:41]

sahel@chromium.org changed reviewers:
+ bokan@chromium.org

[sahel, 2017-03-02 21:03:42]

For now ScrollByTouchand ScrollByWheel values are unused. I added them to have
all of these values next to each other in the use counter enum. I will measure
frequency of wheel and touch scrolls in a follow up cl.

[dtapuska, 2017-03-03 02:01:17]

On 2017/03/02 21:03:42, sahel wrote:
> For now ScrollByTouchand ScrollByWheel values are unused. I added them to have
> all of these values next to each other in the use counter enum. I will measure
> frequency of wheel and touch scrolls in a follow up cl.

drive by lgtm

[bokan, 2017-03-03 15:14:17]

lgtm

[sahel, 2017-03-03 15:48:15]

Description was changed from

==========
UMA metrics for counting different ways of scrolling by keyboard.

BUG=697611
TEST=LayoutTests/fast/events/keyboard-scroll-use-count.html
==========

to

==========
UMA metrics for counting different ways of scrolling by keyboard.

TBR=mkwst@chromium.org
BUG=697611
TEST=LayoutTests/fast/events/keyboard-scroll-use-count.html
==========

[sahel, 2017-03-03 15:48:32]

The CQ bit was checked by sahel@chromium.org

[commit-bot: I haz the power, 2017-03-03 15:48:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 15:54:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 15:54:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bokan, 2017-03-03 15:55:28]

On 2017/03/03 15:54:16, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

You need an OWNER from tools/metrics/OWNERS

[dtapuska, 2017-03-03 15:58:58]

On 2017/03/03 15:55:28, bokan wrote:
> On 2017/03/03 15:54:16, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> You need an OWNER from tools/metrics/OWNERS

It is ok to TBR histogram owners for use counter updates. And sahel did that.
But this is a merge conflict.

[sahel, 2017-03-03 16:09:11]

The CQ bit was checked by sahel@chromium.org

[sahel, 2017-03-03 16:09:11]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2729923002/#ps40001
(title: "histogram merge conflicts resolved.")

[commit-bot: I haz the power, 2017-03-03 16:09:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bokan, 2017-03-03 16:17:49]

On 2017/03/03 15:58:58, dtapuska wrote:
> On 2017/03/03 15:55:28, bokan wrote:
> > On 2017/03/03 15:54:16, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > 
> > You need an OWNER from tools/metrics/OWNERS
> 
> It is ok to TBR histogram owners for use counter updates. And sahel did that.
> But this is a merge conflict.

My bad, I missed the TBR. Carry on...

[commit-bot: I haz the power, 2017-03-03 18:06:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488557351324800,
"parent_rev": "477d1f7294ce5a7b13ce399ca4da899b667547a5", "commit_rev":
"200362b9d0f8bb3748364f8d4938ec6333cf47ab"}

[commit-bot: I haz the power, 2017-03-03 18:07:31]

Description was changed from

==========
UMA metrics for counting different ways of scrolling by keyboard.

TBR=mkwst@chromium.org
BUG=697611
TEST=LayoutTests/fast/events/keyboard-scroll-use-count.html
==========

to

==========
UMA metrics for counting different ways of scrolling by keyboard.

TBR=mkwst@chromium.org
BUG=697611
TEST=LayoutTests/fast/events/keyboard-scroll-use-count.html

Review-Url: https://codereview.chromium.org/2729923002
Cr-Commit-Position: refs/heads/master@{#454619}
Committed:
https://chromium.googlesource.com/chromium/src/+/200362b9d0f8bb3748364f8d4938...
==========

[commit-bot: I haz the power, 2017-03-03 18:07:32]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/200362b9d0f8bb3748364f8d4938...