Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2729903003: Isolate strictly unbreakable multicol containers that are nested. (Closed)

Created:
3 years, 9 months ago by mstensho (USE GERRIT)
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Isolate strictly unbreakable multicol containers that are nested. A strictly unbreakable object (i.e. when getPaginationBreakability() == ForbidBreaks) has no valid break points inside. This is the case for e.g. images, writing mode roots and scrollable objects. If such an object is an inner multicol container, column content inside shouldn't interact with enclosing columns. BUG=696726, 695535, 675070 Review-Url: https://codereview.chromium.org/2729903003 Cr-Commit-Position: refs/heads/master@{#454765} Committed: https://chromium.googlesource.com/chromium/src/+/52c98e8a1b2a5100406e2bdd5d4dc2f444e061c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/nested-and-unbreakable-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/nested-writing-mode-root-crash.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h View 1 chunk +17 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 9 months ago (2017-03-03 19:54:13 UTC) #6
eae
LGTM
3 years, 9 months ago (2017-03-04 05:19:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729903003/1
3 years, 9 months ago (2017-03-04 06:07:17 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 06:12:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/52c98e8a1b2a5100406e2bdd5d4d...

Powered by Google App Engine
This is Rietveld 408576698