Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2729893002: Page load metrics: improve flaky CSSTiming (Closed)

Created:
3 years, 9 months ago by mattcary
Modified:
3 years, 9 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Page load metrics: improve flaky CSSTiming Make CSSTiming less flaky by waiting for the style updated event. BUG=697761 Review-Url: https://codereview.chromium.org/2729893002 Cr-Commit-Position: refs/heads/master@{#454553} Committed: https://chromium.googlesource.com/chromium/src/+/dcdc81fcde2b5b40f42023a5bdb46e6c7c6b08ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mattcary
3 years, 9 months ago (2017-03-02 15:52:45 UTC) #2
Charlie Harrison
LGTM
3 years, 9 months ago (2017-03-02 16:22:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729893002/1
3 years, 9 months ago (2017-03-03 09:17:44 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 09:53:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dcdc81fcde2b5b40f42023a5bdb4...

Powered by Google App Engine
This is Rietveld 408576698