Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2729853008: change clang-format settings in docs/vscode.md and docs/qtcreator.md (Closed)

Created:
3 years, 9 months ago by chaopeng
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

change clang-format settings in docs/vscode.md and docs/qtcreator.md BUG= Review-Url: https://codereview.chromium.org/2729853008 Cr-Commit-Position: refs/heads/master@{#454640} Committed: https://chromium.googlesource.com/chromium/src/+/6fca2b025fc31a0baee84e938bdf1383a3be6fb4

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove auto format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M docs/qtcreator.md View 2 chunks +5 lines, -3 lines 0 comments Download
M docs/vscode.md View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
chaopeng
PTAL. Thank you.
3 years, 9 months ago (2017-03-03 16:35:12 UTC) #2
Nico
lgtm https://codereview.chromium.org/2729853008/diff/1/docs/vscode.md File docs/vscode.md (right): https://codereview.chromium.org/2729853008/diff/1/docs/vscode.md#newcode49 docs/vscode.md:49: "editor.formatOnSave": true i wouldn't set this; much of ...
3 years, 9 months ago (2017-03-03 18:28:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729853008/20001
3 years, 9 months ago (2017-03-03 18:59:32 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 19:11:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6fca2b025fc31a0baee84e938bdf...

Powered by Google App Engine
This is Rietveld 408576698