Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2729853005: Stop password migration from the Keychain on Mac. (Closed)

Created:
3 years, 9 months ago by vasilii
Modified:
3 years, 9 months ago
Reviewers:
jdoerrie
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop password migration from the Keychain on Mac. Chrome is changing the certificate soon because the current one expires. Thus, the passwords created by Chrome in the Keychain become inaccessible. There is no point in trying the migration anymore. We just clean the database (it has no password values, only metadata) and start from scratch. BUG=595468 Review-Url: https://codereview.chromium.org/2729853005 Cr-Commit-Position: refs/heads/master@{#454293} Committed: https://chromium.googlesource.com/chromium/src/+/f31a6d6b2038f1987ff4106e9c833e78ad9ae73c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M chrome/browser/password_manager/password_store_proxy_mac.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M components/password_manager/core/browser/keychain_migration_status_mac.h View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (9 generated)
vasilii
Hi Jan, please review
3 years, 9 months ago (2017-03-02 16:51:10 UTC) #2
jdoerrie
LGTM % comment https://codereview.chromium.org/2729853005/diff/1/components/password_manager/core/browser/keychain_migration_status_mac.h File components/password_manager/core/browser/keychain_migration_status_mac.h (right): https://codereview.chromium.org/2729853005/diff/1/components/password_manager/core/browser/keychain_migration_status_mac.h#newcode33 components/password_manager/core/browser/keychain_migration_status_mac.h:33: // changes the certificate. Could you ...
3 years, 9 months ago (2017-03-02 17:02:28 UTC) #6
vasilii
On 2017/03/02 17:02:28, jdoerrie wrote: > LGTM % comment > > https://codereview.chromium.org/2729853005/diff/1/components/password_manager/core/browser/keychain_migration_status_mac.h > File components/password_manager/core/browser/keychain_migration_status_mac.h ...
3 years, 9 months ago (2017-03-02 17:05:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729853005/1
3 years, 9 months ago (2017-03-02 17:05:40 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 17:29:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f31a6d6b2038f1987ff4106e9c83...

Powered by Google App Engine
This is Rietveld 408576698