DevTools: Support reading CPU profile format on Performance panel

DevTools: Support reading CPU profile format on Performance panel

BUG=697953
Review-Url: https://codereview.chromium.org/2729793003
Cr-Commit-Position: refs/heads/master@{#454434}
Committed: https://chromium.googlesource.com/chromium/src/+/73a34473d6cc86352f226be7186e1e292fe35734

[alph, 2017-03-02 18:29:51]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-03-02 19:00:40]

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
(right):

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:700:
if (initiator && (initiator.endTime || initiator.startTime) < event.startTime &&
revert?

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
(right):

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:236:
* @param {*} profile
?Object

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:246:
for (var i = 0; i < profile.nodes.length; ++i)
profile['nodes']...

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:261:
if (state === name)
Let's keep the state space separate from names space (like automatons that have
input alphabet separate from state set).

[alph, 2017-03-02 19:20:01]

ptal

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
(right):

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:700:
if (initiator && (initiator.endTime || initiator.startTime) < event.startTime &&
On 2017/03/02 19:00:40, caseq wrote:
> revert?

Done.

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
(right):

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:236:
* @param {*} profile
On 2017/03/02 19:00:40, caseq wrote:
> ?Object

This actually could be anything, as it comes out of JSON.parse.
We handle bad cases with try-catch.

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:246:
for (var i = 0; i < profile.nodes.length; ++i)
On 2017/03/02 19:00:40, caseq wrote:
> profile['nodes']...

Done.

https://codereview.chromium.org/2729793003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:261:
if (state === name)
On 2017/03/02 19:00:40, caseq wrote:
> Let's keep the state space separate from names space (like automatons that
have
> input alphabet separate from state set).

Done.

[alph, 2017-03-02 19:21:05]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 19:21:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 20:29:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 20:29:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2017-03-02 21:27:05]

lgtm

https://codereview.chromium.org/2729793003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js
(right):

https://codereview.chromium.org/2729793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js:246:
this._tracingModel.addEvents(traceEvents);
this one could be out of try {}

https://codereview.chromium.org/2729793003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
(right):

https://codereview.chromium.org/2729793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:242:
var start = profile.startTime;
remove start, assign directly?

https://codereview.chromium.org/2729793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:263:
var name = node.callFrame.functionName;
topFunctionName?

[alph, 2017-03-02 22:17:25]

https://codereview.chromium.org/2729793003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js
(right):

https://codereview.chromium.org/2729793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js:246:
this._tracingModel.addEvents(traceEvents);
On 2017/03/02 21:27:05, caseq wrote:
> this one could be out of try {}

Done.

https://codereview.chromium.org/2729793003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js
(right):

https://codereview.chromium.org/2729793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:242:
var start = profile.startTime;
On 2017/03/02 21:27:05, caseq wrote:
> remove start, assign directly?

Done.

https://codereview.chromium.org/2729793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js:263:
var name = node.callFrame.functionName;
On 2017/03/02 21:27:05, caseq wrote:
> topFunctionName?

Let me keep it. It's not important that it's a top function. What I need here is
to distinguish between (idle), (program), and any JS function.

[alph, 2017-03-02 22:19:03]

The CQ bit was checked by alph@chromium.org

[alph, 2017-03-02 22:19:04]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2729793003/#ps40001
(title: "addressing comments")

[commit-bot: I haz the power, 2017-03-02 22:19:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 23:39:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488493143071790,
"parent_rev": "d005809c83c0ad0b9cbbda6b10b7ed2c3dcd5120", "commit_rev":
"73a34473d6cc86352f226be7186e1e292fe35734"}

[commit-bot: I haz the power, 2017-03-02 23:40:34]

Description was changed from

==========
DevTools: Support reading CPU profile format on Performance panel

BUG=697953
==========

to

==========
DevTools: Support reading CPU profile format on Performance panel

BUG=697953

Review-Url: https://codereview.chromium.org/2729793003
Cr-Commit-Position: refs/heads/master@{#454434}
Committed:
https://chromium.googlesource.com/chromium/src/+/73a34473d6cc86352f226be7186e...
==========

[commit-bot: I haz the power, 2017-03-02 23:40:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/73a34473d6cc86352f226be7186e...