Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2729773005: [DevTools] 'Continue to location markers' should be always correctly shown (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 delete this._blackboxInfobar; 154 delete this._blackboxInfobar;
155 } 155 }
156 156
157 /** 157 /**
158 * @override 158 * @override
159 */ 159 */
160 wasShown() { 160 wasShown() {
161 super.wasShown(); 161 super.wasShown();
162 if (this._executionLocation && this.loaded) { 162 if (this._executionLocation && this.loaded) {
163 // We need SourcesTextEditor to be initialized prior to this call. @see cr bug.com/499889 163 // We need SourcesTextEditor to be initialized prior to this call. @see cr bug.com/499889
164 setImmediate(this._generateValuesInSource.bind(this)); 164 setImmediate(() => {
165 this._generateValuesInSource();
166 if (Runtime.experiments.isEnabled('continueToLocationMarkers'))
167 this._showContinueToLocations();
168 });
165 } 169 }
166 } 170 }
167 171
168 /** 172 /**
169 * @override 173 * @override
170 */ 174 */
171 willHide() { 175 willHide() {
172 super.willHide(); 176 super.willHide();
173 this._popoverHelper.hidePopover(); 177 this._popoverHelper.hidePopover();
174 } 178 }
(...skipping 1266 matching lines...) Expand 10 before | Expand all | Expand 10 after
1441 return; 1445 return;
1442 this.bookmark.clear(); 1446 this.bookmark.clear();
1443 this.bookmark = null; 1447 this.bookmark = null;
1444 } 1448 }
1445 }; 1449 };
1446 1450
1447 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark'); 1451 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark');
1448 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element'); 1452 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element');
1449 1453
1450 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol = Symbol('bookm ark'); 1454 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol = Symbol('bookm ark');
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698