Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2729773005: [DevTools] 'Continue to location markers' should be always correctly shown (Closed)

Created:
3 years, 9 months ago by kozy
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] 'Continue to location markers' should be always correctly shown We should follow inline values behavior and independently when setExecutionLocation was called - currently show markers. BUG=chromium:695236 R=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2729773005 Cr-Commit-Position: refs/heads/master@{#454484} Committed: https://chromium.googlesource.com/chromium/src/+/9c2c178bf2d446aefeb2b7a24c7cf55856e10b0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
kozy
Andrey, please take a look!
3 years, 9 months ago (2017-03-02 23:17:18 UTC) #1
lushnikov
lgtm
3 years, 9 months ago (2017-03-02 23:23:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729773005/1
3 years, 9 months ago (2017-03-02 23:53:40 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 02:56:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c2c178bf2d446aefeb2b7a24c7c...

Powered by Google App Engine
This is Rietveld 408576698