|
|
Created:
3 years, 9 months ago by Sam McNally Modified:
3 years, 9 months ago CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, jam Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange ServiceManagerConnectionImpl to run service request handlers on the IO thread.
Currently, ServiceManagerConnectionImpl posts to the main thread to run
service request handlers. This prevents services from being launched
before the main message loop starts. The pref service needs to launch
before the main message loop starts. This CL fixes this by running
service request handlers directly on the IO thread.
BUG=654988
Review-Url: https://codereview.chromium.org/2729733003
Cr-Original-Commit-Position: refs/heads/master@{#455295}
Committed: https://chromium.googlesource.com/chromium/src/+/072bd1f5e01408854503b640c9ad62216d9b6b76
Review-Url: https://codereview.chromium.org/2729733003
Cr-Commit-Position: refs/heads/master@{#456316}
Committed: https://chromium.googlesource.com/chromium/src/+/030f501c3474280e3a0571e8ea71d1c7a1cfed28
Patch Set 1 : #Patch Set 2 : rebase #Patch Set 3 : #Patch Set 4 : rebase #Patch Set 5 : Fix startup race. #
Messages
Total messages: 52 (42 generated)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Description was changed from ========== Change ServiceManagerConnectionImpl to run service request handlers on the IO thread. Currently, ServiceManagerConnectionImpl posts to the main thread to run service request handlers. This prevents services from being launched before the main message loop starts. Prefs needs to launch before the main message loop starts. This CL fixes this by running service request handlers directly on the IO thread. BUG=654988 ========== to ========== Change ServiceManagerConnectionImpl to run service request handlers on the IO thread. Currently, ServiceManagerConnectionImpl posts to the main thread to run service request handlers. This prevents services from being launched before the main message loop starts. The pref service needs to launch before the main message loop starts. This CL fixes this by running service request handlers directly on the IO thread. BUG=654988 ==========
sammc@chromium.org changed reviewers: + rockot@chromium.org
lgtm
sammc@chromium.org changed reviewers: + jochen@chromium.org
+jochen for //content/browser/browser_context.cc
can you add a test please?
Patchset #2 (id:80001) has been deleted
Patchset #3 (id:120001) has been deleted
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/06 12:57:02, jochen wrote: > can you add a test please? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
lgtm
The CQ bit was checked by sammc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org Link to the patchset: https://codereview.chromium.org/2729733003/#ps140001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 140001, "attempt_start_ts": 1488925762057960, "parent_rev": "fec2991e99c468610b90b26f1aa017cfe2834af8", "commit_rev": "072bd1f5e01408854503b640c9ad62216d9b6b76"}
Message was sent while issue was closed.
Description was changed from ========== Change ServiceManagerConnectionImpl to run service request handlers on the IO thread. Currently, ServiceManagerConnectionImpl posts to the main thread to run service request handlers. This prevents services from being launched before the main message loop starts. The pref service needs to launch before the main message loop starts. This CL fixes this by running service request handlers directly on the IO thread. BUG=654988 ========== to ========== Change ServiceManagerConnectionImpl to run service request handlers on the IO thread. Currently, ServiceManagerConnectionImpl posts to the main thread to run service request handlers. This prevents services from being launched before the main message loop starts. The pref service needs to launch before the main message loop starts. This CL fixes this by running service request handlers directly on the IO thread. BUG=654988 Review-Url: https://codereview.chromium.org/2729733003 Cr-Commit-Position: refs/heads/master@{#455295} Committed: https://chromium.googlesource.com/chromium/src/+/072bd1f5e01408854503b640c9ad... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:140001) as https://chromium.googlesource.com/chromium/src/+/072bd1f5e01408854503b640c9ad...
Message was sent while issue was closed.
Description was changed from ========== Change ServiceManagerConnectionImpl to run service request handlers on the IO thread. Currently, ServiceManagerConnectionImpl posts to the main thread to run service request handlers. This prevents services from being launched before the main message loop starts. The pref service needs to launch before the main message loop starts. This CL fixes this by running service request handlers directly on the IO thread. BUG=654988 Review-Url: https://codereview.chromium.org/2729733003 Cr-Commit-Position: refs/heads/master@{#455295} Committed: https://chromium.googlesource.com/chromium/src/+/072bd1f5e01408854503b640c9ad... ========== to ========== Change ServiceManagerConnectionImpl to run service request handlers on the IO thread. Currently, ServiceManagerConnectionImpl posts to the main thread to run service request handlers. This prevents services from being launched before the main message loop starts. The pref service needs to launch before the main message loop starts. This CL fixes this by running service request handlers directly on the IO thread. BUG=654988 Review-Url: https://codereview.chromium.org/2729733003 Cr-Commit-Position: refs/heads/master@{#455295} Committed: https://chromium.googlesource.com/chromium/src/+/072bd1f5e01408854503b640c9ad... ==========
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #4 (id:160001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sammc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2729733003/#ps200001 (title: "Fix startup race.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 200001, "attempt_start_ts": 1489371885059290, "parent_rev": "fd92641a50fb746ad1cee17fc3bcbcdb849fd9ee", "commit_rev": "030f501c3474280e3a0571e8ea71d1c7a1cfed28"}
Message was sent while issue was closed.
Description was changed from ========== Change ServiceManagerConnectionImpl to run service request handlers on the IO thread. Currently, ServiceManagerConnectionImpl posts to the main thread to run service request handlers. This prevents services from being launched before the main message loop starts. The pref service needs to launch before the main message loop starts. This CL fixes this by running service request handlers directly on the IO thread. BUG=654988 Review-Url: https://codereview.chromium.org/2729733003 Cr-Commit-Position: refs/heads/master@{#455295} Committed: https://chromium.googlesource.com/chromium/src/+/072bd1f5e01408854503b640c9ad... ========== to ========== Change ServiceManagerConnectionImpl to run service request handlers on the IO thread. Currently, ServiceManagerConnectionImpl posts to the main thread to run service request handlers. This prevents services from being launched before the main message loop starts. The pref service needs to launch before the main message loop starts. This CL fixes this by running service request handlers directly on the IO thread. BUG=654988 Review-Url: https://codereview.chromium.org/2729733003 Cr-Original-Commit-Position: refs/heads/master@{#455295} Committed: https://chromium.googlesource.com/chromium/src/+/072bd1f5e01408854503b640c9ad... Review-Url: https://codereview.chromium.org/2729733003 Cr-Commit-Position: refs/heads/master@{#456316} Committed: https://chromium.googlesource.com/chromium/src/+/030f501c3474280e3a0571e8ea71... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:200001) as https://chromium.googlesource.com/chromium/src/+/030f501c3474280e3a0571e8ea71... |