Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2729733003: Change ServiceManagerConnectionImpl to run service request handlers on the IO thread. (Closed)

Created:
3 years, 9 months ago by Sam McNally
Modified:
3 years, 9 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ServiceManagerConnectionImpl to run service request handlers on the IO thread. Currently, ServiceManagerConnectionImpl posts to the main thread to run service request handlers. This prevents services from being launched before the main message loop starts. The pref service needs to launch before the main message loop starts. This CL fixes this by running service request handlers directly on the IO thread. BUG=654988 Review-Url: https://codereview.chromium.org/2729733003 Cr-Original-Commit-Position: refs/heads/master@{#455295} Committed: https://chromium.googlesource.com/chromium/src/+/072bd1f5e01408854503b640c9ad62216d9b6b76 Review-Url: https://codereview.chromium.org/2729733003 Cr-Commit-Position: refs/heads/master@{#456316} Committed: https://chromium.googlesource.com/chromium/src/+/030f501c3474280e3a0571e8ea71d1c7a1cfed28

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : Fix startup race. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -74 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_context.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 4 chunks +17 lines, -32 lines 0 comments Download
M content/common/service_manager/service_manager_connection_impl.h View 1 2 4 chunks +3 lines, -8 lines 0 comments Download
M content/common/service_manager/service_manager_connection_impl.cc View 1 2 3 4 12 chunks +49 lines, -33 lines 0 comments Download
A content/common/service_manager/service_manager_connection_impl_unittest.cc View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 52 (42 generated)
Sam McNally
3 years, 9 months ago (2017-03-03 05:18:58 UTC) #20
Ken Rockot(use gerrit already)
lgtm
3 years, 9 months ago (2017-03-03 17:40:49 UTC) #21
Sam McNally
+jochen for //content/browser/browser_context.cc
3 years, 9 months ago (2017-03-05 23:22:27 UTC) #23
jochen (gone - plz use gerrit)
can you add a test please?
3 years, 9 months ago (2017-03-06 12:57:02 UTC) #24
Sam McNally
On 2017/03/06 12:57:02, jochen wrote: > can you add a test please? Done.
3 years, 9 months ago (2017-03-07 01:53:47 UTC) #29
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-07 11:50:51 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729733003/140001
3 years, 9 months ago (2017-03-07 22:30:42 UTC) #35
commit-bot: I haz the power
Committed patchset #3 (id:140001) as https://chromium.googlesource.com/chromium/src/+/072bd1f5e01408854503b640c9ad62216d9b6b76
3 years, 9 months ago (2017-03-07 23:51:38 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729733003/200001
3 years, 9 months ago (2017-03-13 02:24:53 UTC) #49
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 02:29:36 UTC) #52
Message was sent while issue was closed.
Committed patchset #5 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/030f501c3474280e3a0571e8ea71...

Powered by Google App Engine
This is Rietveld 408576698