Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2729693002: MD Settings: Internet: Hide add connection UI when WiFi is disabled (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Hide add connection UI when WiFi is disabled BUG=157287 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2729693002 Cr-Commit-Position: refs/heads/master@{#454417} Committed: https://chromium.googlesource.com/chromium/src/+/2fd58322bd5db814eac90e29edf9bc9c96d2047e

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M chrome/browser/resources/settings/internet_page/internet_page.html View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.js View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_subpage.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
stevenjb
3 years, 9 months ago (2017-03-01 21:18:22 UTC) #3
michaelpg
lgtm
3 years, 9 months ago (2017-03-01 23:40:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729693002/20001
3 years, 9 months ago (2017-03-02 20:58:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/6685)
3 years, 9 months ago (2017-03-02 21:16:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729693002/40001
3 years, 9 months ago (2017-03-02 21:42:16 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 22:50:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2fd58322bd5db814eac90e29edf9...

Powered by Google App Engine
This is Rietveld 408576698