Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2729643002:
[Payments] Should not notify onInstrumentDetailsError for getInstruments (Closed)
|
Created:
3 years, 9 months ago by gogerald1 Modified:
3 years, 9 months ago Reviewers:
please use gerrit instead CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionShould not notify onInstrumentDetailsError for getInstruments
BUG=697517
Review-Url: https://codereview.chromium.org/2729643002
Cr-Commit-Position: refs/heads/master@{#453995}
Committed: https://chromium.googlesource.com/chromium/src/+/a3ca447f6268a42db6ebc87acca0a601f28a757d
Patch Set 1 #
Messages
Total messages: 20 (16 generated)
Description was changed from ========== Do not notify onInstrumentDetailsError for getInstruments BUG= ========== to ========== Do not notify onInstrumentDetailsError for getInstruments BUG=697517 ==========
Description was changed from ========== Do not notify onInstrumentDetailsError for getInstruments BUG=697517 ========== to ========== Should not notify onInstrumentDetailsError for getInstruments BUG=697517 ==========
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
The CQ bit was unchecked by gogerald@chromium.org
The CQ bit was checked by gogerald@chromium.org
The CQ bit was unchecked by gogerald@chromium.org
The CQ bit was checked by gogerald@chromium.org
The CQ bit was unchecked by gogerald@chromium.org
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gogerald@chromium.org changed reviewers: + rouslan@chromium.org
Hi rouslan@, PTAL,
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gogerald@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488396012215630, "parent_rev":
"d9d61ec69bdeb53703521c67c4292e148201f084", "commit_rev":
"a3ca447f6268a42db6ebc87acca0a601f28a757d"}
Message was sent while issue was closed.
Description was changed from ========== Should not notify onInstrumentDetailsError for getInstruments BUG=697517 ========== to ========== Should not notify onInstrumentDetailsError for getInstruments BUG=697517 Review-Url: https://codereview.chromium.org/2729643002 Cr-Commit-Position: refs/heads/master@{#453995} Committed: https://chromium.googlesource.com/chromium/src/+/a3ca447f6268a42db6ebc87acca0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a3ca447f6268a42db6ebc87acca0... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
