Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2729633002: mash: Cleanly exit on SIGTERM, SIGINT, SIGHUP (Closed)

Created:
3 years, 9 months ago by James Cook
Modified:
3 years, 9 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Cleanly exit on SIGTERM, SIGINT, SIGHUP This is needed for the Chrome OS session_manager to cleanly shutdown chrome on device shutdown and in tests. It's also useful on Linux desktop to cleanly exit chrome in response to control-C. * Refactor ShutdownDetector and signal handlers out of ChromeBrowserMainPartsPosix. Make it run a shutdown callback. * Use shutdown callback to exit the chrome --mash root process run loop. BUG=697146, 692227, 696696 TEST=stop ui closes chrome quickly, session_manager doesn't send signal 9 anymore, control-C on Linux desktop cleanly exists chrome Review-Url: https://codereview.chromium.org/2729633002 Cr-Commit-Position: refs/heads/master@{#454163} Committed: https://chromium.googlesource.com/chromium/src/+/f154aac6ce85da803ff8263ab287564c619359be

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -191 lines) Patch
M chrome/app/BUILD.gn View 1 chunk +12 lines, -0 lines 1 comment Download
M chrome/app/mash/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/mash/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 2 chunks +13 lines, -0 lines 0 comments Download
A chrome/app/shutdown_signal_handlers_posix.h View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/app/shutdown_signal_handlers_posix.cc View 1 chunk +226 lines, -0 lines 6 comments Download
M chrome/browser/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_posix.cc View 4 chunks +5 lines, -191 lines 1 comment Download

Messages

Total messages: 16 (9 generated)
James Cook
rockot, please take a look. https://codereview.chromium.org/2729633002/diff/1/chrome/app/BUILD.gn File chrome/app/BUILD.gn (right): https://codereview.chromium.org/2729633002/diff/1/chrome/app/BUILD.gn#newcode21 chrome/app/BUILD.gn:21: # because it isn't ...
3 years, 9 months ago (2017-03-01 18:24:39 UTC) #4
Ken Rockot(use gerrit already)
LGTM! chrome/app seems like a reasonable home to me
3 years, 9 months ago (2017-03-01 21:44:23 UTC) #7
James Cook
sky, can I get OWNERS for //chrome/browser?
3 years, 9 months ago (2017-03-01 21:55:02 UTC) #9
sky
LGTM
3 years, 9 months ago (2017-03-02 02:59:51 UTC) #10
James Cook
Thanks, guys!
3 years, 9 months ago (2017-03-02 03:01:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729633002/1
3 years, 9 months ago (2017-03-02 03:01:51 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 03:31:18 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f154aac6ce85da803ff8263ab287...

Powered by Google App Engine
This is Rietveld 408576698