Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2729623006: DevTools: Support wss:// endpoints (Closed)

Created:
3 years, 9 months ago by paulirish
Modified:
3 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Support wss:// endpoints BUG= Review-Url: https://codereview.chromium.org/2729623006 Cr-Commit-Position: refs/heads/master@{#456258} Committed: https://chromium.googlesource.com/chromium/src/+/8925c3c45f3923bc78ffc841842183cc592a0143

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 16 (9 generated)
paulirish
3 years, 9 months ago (2017-03-03 20:59:10 UTC) #4
dgozman
https://codereview.chromium.org/2729623006/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right): https://codereview.chromium.org/2729623006/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js#newcode428 third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:428: var ws = wsParam ? `ws://${wsParam}` : `wss://${wssParam}`; Last ...
3 years, 9 months ago (2017-03-05 06:08:13 UTC) #6
pfeldman
it does not hurt, lgtm
3 years, 9 months ago (2017-03-06 18:08:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729623006/20001
3 years, 9 months ago (2017-03-10 23:25:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/398991)
3 years, 9 months ago (2017-03-11 00:49:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729623006/20001
3 years, 9 months ago (2017-03-11 00:57:45 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 02:19:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8925c3c45f3923bc78ffc8418421...

Powered by Google App Engine
This is Rietveld 408576698