Update vector icons in browser profiles code (bubble, etc.) to structs.

Update vector icons in browser profiles code (bubble, etc.) to structs.

Move icon definitions as appropriate.

BUG=626786
Review-Url: https://codereview.chromium.org/2729623002
Cr-Commit-Position: refs/heads/master@{#454470}
Committed: https://chromium.googlesource.com/chromium/src/+/78fa524fa500c7e54491c0af8d1674555a64e367

[Evan Stade, 2017-03-01 17:57:48]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 17:58:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 18:09:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 18:09:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-03-01 22:07:00]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 22:07:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:34:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2017-03-01 23:22:47]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 23:23:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-03-02 00:43:44]

Description was changed from

==========
Update vector icons in browser profiles code (bubble, etc.) to structs.

Move icon definitions as appropriate.

BUG=
==========

to

==========
Update vector icons in browser profiles code (bubble, etc.) to structs.

Move icon definitions as appropriate.

BUG=626786
==========

[Evan Stade, 2017-03-02 00:43:45]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org, rsesek@chromium.org

[commit-bot: I haz the power, 2017-03-02 00:44:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 00:44:11]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-03-02 00:44:19]

+rsesek for cocoa/
+pkasting for everything else

[Robert Sesek, 2017-03-02 15:05:26]

cocoa/ LGTM

[Peter Kasting, 2017-03-02 23:12:52]

LGTM

https://codereview.chromium.org/2729623002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2729623002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:501: const
gfx::VectorIcon* icon = nullptr;
Nit: I'd avoid initializing this to avoid implying some codepath below might not
do so (and, hopefully, trigger a compiler warning if a path actually failed to
do so).  (2 places)

[Evan Stade, 2017-03-03 00:20:32]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-03 00:20:35]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2729623002/#ps60001
(title: "review")

[commit-bot: I haz the power, 2017-03-03 00:21:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-03-03 00:36:38]

https://codereview.chromium.org/2729623002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2729623002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:501: const
gfx::VectorIcon* icon = nullptr;
On 2017/03/02 23:12:51, Peter Kasting wrote:
> Nit: I'd avoid initializing this to avoid implying some codepath below might
not
> do so (and, hopefully, trigger a compiler warning if a path actually failed to
> do so).  (2 places)

Done.

[commit-bot: I haz the power, 2017-03-03 02:22:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488500432608170,
"parent_rev": "5bc2737ade6958dda45c2085bc2755970a6639ab", "commit_rev":
"78fa524fa500c7e54491c0af8d1674555a64e367"}

[commit-bot: I haz the power, 2017-03-03 02:23:18]

Description was changed from

==========
Update vector icons in browser profiles code (bubble, etc.) to structs.

Move icon definitions as appropriate.

BUG=626786
==========

to

==========
Update vector icons in browser profiles code (bubble, etc.) to structs.

Move icon definitions as appropriate.

BUG=626786

Review-Url: https://codereview.chromium.org/2729623002
Cr-Commit-Position: refs/heads/master@{#454470}
Committed:
https://chromium.googlesource.com/chromium/src/+/78fa524fa500c7e54491c0af8d16...
==========

[commit-bot: I haz the power, 2017-03-03 02:23:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/78fa524fa500c7e54491c0af8d16...