content/browser/web_contents/web_contents_view_mac.mm - Issue 2729613006: When navigation focuses a web contents, also activate its window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_mac.mm

Issue 2729613006: When navigation focuses a web contents, also activate its window. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_mac.mm

diff --git a/content/browser/web_contents/web_contents_view_mac.mm b/content/browser/web_contents/web_contents_view_mac.mm

index b2366393bad700944ddbf977d318b1b59455f8e7..90bb79c8ce423723ae95593bfeb4be49c9030575 100644

--- a/content/browser/web_contents/web_contents_view_mac.mm

+++ b/content/browser/web_contents/web_contents_view_mac.mm

@@ -227,6 +227,7 @@ void WebContentsViewMac::Focus() {

if (![window isVisible])

return;

[window makeKeyAndOrderFront:nil];

+ [NSApp activateIgnoringOtherApps:YES];

Avi (use Gerrit) 2017/03/02 23:26:18 I could swear I've seen this change before. Who e

Sidney San Martín 2017/03/08 05:02:29 One of these? https://codereview.chromium.org/2412

Sidney San Martín 2017/03/08 05:02:29 I'd missed some callers… so, thanks! I found a mor

}

void WebContentsViewMac::SetInitialFocus() {

« no previous file with comments | « chrome/test/data/notifications/notification_tester.html ('k') | no next file » | no next file with comments »