Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2412983004: [Mac] Bring Chrome to the front when the settings button in a notification is clicked. (Closed)

Created:
4 years, 2 months ago by Sidney San Martín
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Bring Chrome to the front when the settings button in a notification is clicked. BUG=655443 Committed: https://crrev.com/c72276b24d4574f8a2ba899c27dff45be4d4cbfd Cr-Commit-Position: refs/heads/master@{#425042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/message_center/cocoa/notification_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sidney San Martín
4 years, 2 months ago (2016-10-13 14:54:27 UTC) #2
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-13 15:04:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412983004/1
4 years, 2 months ago (2016-10-13 15:17:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 15:38:45 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 15:41:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c72276b24d4574f8a2ba899c27dff45be4d4cbfd
Cr-Commit-Position: refs/heads/master@{#425042}

Powered by Google App Engine
This is Rietveld 408576698