[Mac] Remove bookmark bar NIB

[Mac] Remove bookmark bar NIB
BUG=648560
Review-Url: https://codereview.chromium.org/2729603008
Cr-Commit-Position: refs/heads/master@{#455468}
Committed: https://chromium.googlesource.com/chromium/src/+/67b81bc38c7e2164bc77f0c00d11d26d620edc18

[lgrey, 2017-03-03 22:08:52]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 22:09:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 23:12:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 23:12:38]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lgrey, 2017-03-06 17:08:23]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 17:08:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 18:09:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 18:09:17]

Dry run: This issue passed the CQ dry run.

[lgrey, 2017-03-06 18:55:26]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 18:56:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgrey, 2017-03-06 20:47:25]

lgrey@chromium.org changed reviewers:
+ ellyjones@chromium.org

[lgrey, 2017-03-06 20:47:25]

PTAL :)

[commit-bot: I haz the power, 2017-03-06 21:35:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 21:35:34]

Dry run: This issue passed the CQ dry run.

[Elly Fong-Jones, 2017-03-07 16:21:54]

lgtm

https://codereview.chromium.org/2729603008/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm (right):

https://codereview.chromium.org/2729603008/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm:26: -
(void)setController:(id<BookmarkBarToolbarViewController>)controller {
what is this used for?

https://codereview.chromium.org/2729603008/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller.mm (left):

https://codereview.chromium.org/2729603008/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller.mm:335:
[[bookmarkBarController_ controlledView] setResizeDelegate:self];
why does a function called "setResizeDelegate:" load the view? O_o

[lgrey, 2017-03-07 22:07:32]

Also updated the condition for |viewDidLoad| to check for macOS > 10.10 instead
of macOS <= 10.9 per offline discussion

https://codereview.chromium.org/2729603008/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm (right):

https://codereview.chromium.org/2729603008/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm:26: -
(void)setController:(id<BookmarkBarToolbarViewController>)controller {
On 2017/03/07 16:21:54, Elly Fong-Jones wrote:
> what is this used for?

Added a comment in the header (allows the controller to nil itself. Also
actually sets the controller in the first place, but in that case I could have
just put it in the initializer so that's why it's a separate method.)

https://codereview.chromium.org/2729603008/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller.mm (left):

https://codereview.chromium.org/2729603008/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller.mm:335:
[[bookmarkBarController_ controlledView] setResizeDelegate:self];
On 2017/03/07 16:21:54, Elly Fong-Jones wrote:
> why does a function called "setResizeDelegate:" load the view? O_o

It doesn't. |controlledView| calls [self view] which triggers loadView when the
view doesn't exist. Separated this into two statements to (hopefully) make it
clearer.

[lgrey, 2017-03-08 15:17:35]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 15:17:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 16:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 16:24:30]

Dry run: This issue passed the CQ dry run.

[lgrey, 2017-03-08 16:31:15]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2017-03-08 16:31:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
ellyjones@chromium.org
Link to the patchset: https://codereview.chromium.org/2729603008/#ps60001
(title: "CL comments")

[commit-bot: I haz the power, 2017-03-08 16:31:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 16:39:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488990675360470,
"parent_rev": "02ebf8339c19e2972d49d5fbbade603be652bbec", "commit_rev":
"67b81bc38c7e2164bc77f0c00d11d26d620edc18"}

[commit-bot: I haz the power, 2017-03-08 16:40:19]

Description was changed from

==========
[Mac] Remove bookmark bar NIB
BUG=648560
==========

to

==========
[Mac] Remove bookmark bar NIB
BUG=648560

Review-Url: https://codereview.chromium.org/2729603008
Cr-Commit-Position: refs/heads/master@{#455468}
Committed:
https://chromium.googlesource.com/chromium/src/+/67b81bc38c7e2164bc77f0c00d11...
==========

[commit-bot: I haz the power, 2017-03-08 16:40:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/67b81bc38c7e2164bc77f0c00d11...