Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2729603006: Fix Web Bluetooth two iframes from same origin layout test (Closed)

Created:
3 years, 9 months ago by juncai
Modified:
3 years, 9 months ago
Reviewers:
ortuno
CC:
blink-reviews, chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Web Bluetooth two iframes from same origin layout test This CL fixes the test: //third_party/WebKit/LayoutTests/resources/bluetooth/heart-rate-two-iframes.html which doesn't return any promises so it could never fail. BUG=697590 Review-Url: https://codereview.chromium.org/2729603006 Cr-Commit-Position: refs/heads/master@{#454715} Committed: https://chromium.googlesource.com/chromium/src/+/82200bccb1df8a4a6a9923344b48f80f0b6f2cdd

Patch Set 1 : fix Web Bluetooth two iframes from same origin layout test #

Patch Set 2 : updated test code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/two-iframes-from-same-origin.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/bluetooth/heart-rate-two-iframes.html View 1 2 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
juncai
Please take a look.
3 years, 9 months ago (2017-03-02 22:27:46 UTC) #4
ortuno
Nice. Could we also have the opposite test? Two frames from different origins accessing trying ...
3 years, 9 months ago (2017-03-02 23:46:28 UTC) #7
ortuno
As discussed offline we already have unit tests for the mentioned case and since we ...
3 years, 9 months ago (2017-03-03 22:17:19 UTC) #8
ortuno
lgtm!
3 years, 9 months ago (2017-03-03 22:25:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729603006/20001
3 years, 9 months ago (2017-03-03 23:46:38 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 23:53:52 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/82200bccb1df8a4a6a9923344b48...

Powered by Google App Engine
This is Rietveld 408576698