Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/predictors/resource_prefetch_common.cc

Issue 2729563002: predictors: Disable URL-based learning by default. (Closed)
Patch Set: Get rid of URL-only. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_common.cc
diff --git a/chrome/browser/predictors/resource_prefetch_common.cc b/chrome/browser/predictors/resource_prefetch_common.cc
index 27ea7933c98834c5ddcc57903fc9775dce60cd82..84176f300cbaf82a9c71c380e9822007227ec1f0 100644
--- a/chrome/browser/predictors/resource_prefetch_common.cc
+++ b/chrome/browser/predictors/resource_prefetch_common.cc
@@ -7,14 +7,12 @@
#include <string>
#include <tuple>
-#include "base/command_line.h"
-#include "base/metrics/field_trial.h"
+#include "base/feature_list.h"
+#include "base/metrics/field_trial_params.h"
#include "chrome/browser/net/prediction_options.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sessions/session_tab_helper.h"
-#include "chrome/common/chrome_switches.h"
#include "components/prefs/pref_service.h"
-#include "components/variations/variations_associated_data.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
@@ -26,6 +24,7 @@ const char kModeParamName[] = "mode";
const char kLearningMode[] = "learning";
const char kExternalPrefetchingMode[] = "external-prefetching";
const char kPrefetchingMode[] = "prefetching";
+const char kEnableUrlLearningParamName[] = "enable-url-learning";
namespace {
@@ -61,7 +60,14 @@ bool IsSpeculativeResourcePrefetchingEnabled(
if (!base::FeatureList::IsEnabled(kSpeculativeResourcePrefetchingFeature))
return false;
- std::string mode_value = variations::GetVariationParamValueByFeature(
+ std::string enable_url_learning_value =
+ base::GetFieldTrialParamValueByFeature(
+ kSpeculativeResourcePrefetchingFeature, kEnableUrlLearningParamName);
+ if (enable_url_learning_value == "true") {
+ config->is_url_learning_enabled = true;
+ }
+
+ std::string mode_value = base::GetFieldTrialParamValueByFeature(
kSpeculativeResourcePrefetchingFeature, kModeParamName);
if (mode_value == kLearningMode) {
config->mode |= ResourcePrefetchPredictorConfig::LEARNING;

Powered by Google App Engine
This is Rietveld 408576698