Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

Issue 2729563002: predictors: Disable URL-based learning by default. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor _page_load_metrics_observer.h" 5 #include "chrome/browser/page_load_metrics/observers/resource_prefetch_predictor _page_load_metrics_observer.h"
6 6
7 #include <memory>
8
7 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_ test_harness.h" 10 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_ test_harness.h"
9 #include "chrome/browser/predictors/resource_prefetch_common.h" 11 #include "chrome/browser/predictors/resource_prefetch_common.h"
10 #include "chrome/browser/predictors/resource_prefetch_predictor.h" 12 #include "chrome/browser/predictors/resource_prefetch_predictor.h"
11 #include "chrome/test/base/testing_profile.h" 13 #include "chrome/test/base/testing_profile.h"
12 #include "content/public/test/test_browser_thread_bundle.h" 14 #include "content/public/test/test_browser_thread_bundle.h"
13 #include "testing/gmock/include/gmock/gmock.h" 15 #include "testing/gmock/include/gmock/gmock.h"
14 16
15 using predictors::ResourcePrefetchPredictor; 17 using predictors::ResourcePrefetchPredictor;
16 18
17 class MockResourcePrefetchPredictor : public ResourcePrefetchPredictor { 19 class MockResourcePrefetchPredictor : public ResourcePrefetchPredictor {
18 public: 20 public:
19 MockResourcePrefetchPredictor( 21 MockResourcePrefetchPredictor(
20 const predictors::ResourcePrefetchPredictorConfig& config, 22 const predictors::ResourcePrefetchPredictorConfig& config,
21 Profile* profile) 23 Profile* profile)
22 : ResourcePrefetchPredictor(config, profile) {} 24 : ResourcePrefetchPredictor(config, profile) {}
23 25
24 MOCK_METHOD1(IsUrlPrefetchable, bool(const GURL& main_frame_url)); 26 MOCK_METHOD1(IsUrlPrefetchable, bool(const GURL& main_frame_url));
25 27
26 ~MockResourcePrefetchPredictor() override {} 28 ~MockResourcePrefetchPredictor() override {}
27 }; 29 };
28 30
29 class ResourcePrefetchPredictorPageLoadMetricsObserverTest 31 class ResourcePrefetchPredictorPageLoadMetricsObserverTest
30 : public page_load_metrics::PageLoadMetricsObserverTestHarness { 32 : public page_load_metrics::PageLoadMetricsObserverTestHarness {
31 protected: 33 protected:
32 void SetUp() override { 34 void SetUp() override {
33 page_load_metrics::PageLoadMetricsObserverTestHarness::SetUp(); 35 page_load_metrics::PageLoadMetricsObserverTestHarness::SetUp();
34 predictors::ResourcePrefetchPredictorConfig config; 36 predictors::ResourcePrefetchPredictorConfig config;
35 config.mode = predictors::ResourcePrefetchPredictorConfig::LEARNING; 37 config.mode = predictors::ResourcePrefetchPredictorConfig::HOST_LEARNING;
36 predictor_ = 38 predictor_ =
37 base::MakeUnique<testing::StrictMock<MockResourcePrefetchPredictor>>( 39 base::MakeUnique<testing::StrictMock<MockResourcePrefetchPredictor>>(
38 config, profile()); 40 config, profile());
39 timing_.navigation_start = base::Time::FromDoubleT(1); 41 timing_.navigation_start = base::Time::FromDoubleT(1);
40 timing_.first_paint = base::TimeDelta::FromSeconds(2); 42 timing_.first_paint = base::TimeDelta::FromSeconds(2);
41 timing_.first_contentful_paint = base::TimeDelta::FromSeconds(3); 43 timing_.first_contentful_paint = base::TimeDelta::FromSeconds(3);
42 timing_.first_meaningful_paint = base::TimeDelta::FromSeconds(4); 44 timing_.first_meaningful_paint = base::TimeDelta::FromSeconds(4);
43 PopulateRequiredTimingFields(&timing_); 45 PopulateRequiredTimingFields(&timing_);
44 } 46 }
45 47
(...skipping 30 matching lines...) Expand all
76 .WillOnce(testing::Return(false)); 78 .WillOnce(testing::Return(false));
77 79
78 NavigateAndCommit(main_frame_url); 80 NavigateAndCommit(main_frame_url);
79 SimulateTimingUpdate(timing_); 81 SimulateTimingUpdate(timing_);
80 82
81 histogram_tester().ExpectTotalCount( 83 histogram_tester().ExpectTotalCount(
82 internal::kHistogramResourcePrefetchPredictorFirstContentfulPaint, 0); 84 internal::kHistogramResourcePrefetchPredictorFirstContentfulPaint, 0);
83 histogram_tester().ExpectTotalCount( 85 histogram_tester().ExpectTotalCount(
84 internal::kHistogramResourcePrefetchPredictorFirstMeaningfulPaint, 0); 86 internal::kHistogramResourcePrefetchPredictorFirstMeaningfulPaint, 0);
85 } 87 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698