Add accessibility label to Reading List empty background

Add accessibility label to Reading List empty background

The automatic accessibility label is not read correctly in iOS 9. This CL fixes
it by giving a specific accessibility label.

BUG=697005
Review-Url: https://codereview.chromium.org/2729553002
Cr-Commit-Position: refs/heads/master@{#453928}
Committed: https://chromium.googlesource.com/chromium/src/+/0e7f688a4f922d65757f9ea44e495255b541c253

[gambard, 2017-03-01 12:41:00]

gambard@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[gambard, 2017-03-01 12:41:01]

PTAL.

[Olivier, 2017-03-01 13:19:22]

LGTM with nits.

https://codereview.chromium.org/2729553002/diff/1/ios/chrome/browser/ui/readi...
File
ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm
(right):

https://codereview.chromium.org/2729553002/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm:125:
IDS_IOS_TOOLBAR_SETTINGS)]
nit: create a bar for this accessibility string and reuse it on lines 116 and
124.

same below.

[Olivier, 2017-03-01 13:21:39]

https://codereview.chromium.org/2729553002/diff/1/ios/chrome/browser/ui/readi...
File
ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm
(right):

https://codereview.chromium.org/2729553002/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm:125:
IDS_IOS_TOOLBAR_SETTINGS)]
On 2017/03/01 13:19:22, Olivier Robin wrote:
> nit: create a bar for this accessibility string and reuse it on lines 116 and
> 124.
> 
> same below.

s/bar/var/

[gambard, 2017-03-01 13:56:09]

Thanks!

https://codereview.chromium.org/2729553002/diff/1/ios/chrome/browser/ui/readi...
File
ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm
(right):

https://codereview.chromium.org/2729553002/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm:125:
IDS_IOS_TOOLBAR_SETTINGS)]
On 2017/03/01 13:21:39, Olivier Robin wrote:
> On 2017/03/01 13:19:22, Olivier Robin wrote:
> > nit: create a bar for this accessibility string and reuse it on lines 116
and
> > 124.
> > 
> > same below.
> 
> s/bar/var/

I removed it from line 116.

[gambard, 2017-03-01 13:56:14]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-03-01 13:56:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
olivierrobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2729553002/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2017-03-01 13:56:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 14:07:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488376574341710,
"parent_rev": "8579f022a226b0182ba7c5a0a2b83815775a1faa", "commit_rev":
"0e7f688a4f922d65757f9ea44e495255b541c253"}

[commit-bot: I haz the power, 2017-03-01 14:08:04]

Description was changed from

==========
Add accessibility label to Reading List empty background

The automatic accessibility label is not read correctly in iOS 9. This CL fixes
it by giving a specific accessibility label.

BUG=697005
==========

to

==========
Add accessibility label to Reading List empty background

The automatic accessibility label is not read correctly in iOS 9. This CL fixes
it by giving a specific accessibility label.

BUG=697005

Review-Url: https://codereview.chromium.org/2729553002
Cr-Commit-Position: refs/heads/master@{#453928}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e7f688a4f922d65757f9ea44e49...
==========

[commit-bot: I haz the power, 2017-03-01 14:08:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e7f688a4f922d65757f9ea44e49...