Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2729543004: Sync the FeatureObserver (UseCounter) metric in histograms.xml (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
haraken, Mike West
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync the FeatureObserver (UseCounter) metric in histograms.xml Catching up with changes to Blink's third_party/WebKit/Source/core/frame/UseCounter.h. Review-Url: https://codereview.chromium.org/2729543004 Cr-Commit-Position: refs/heads/master@{#454280} Committed: https://chromium.googlesource.com/chromium/src/+/31327f5499325cdcbcb70b83863f38b7e6cecd1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fs
3 years, 9 months ago (2017-03-02 14:36:27 UTC) #2
haraken
LGTM (though we should have added them to histograms.xml when we landed the use counters ...
3 years, 9 months ago (2017-03-02 14:45:13 UTC) #3
fs
On 2017/03/02 at 14:45:13, haraken wrote: > LGTM (though we should have added them to ...
3 years, 9 months ago (2017-03-02 15:01:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729543004/1
3 years, 9 months ago (2017-03-02 15:02:20 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 16:37:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/31327f5499325cdcbcb70b83863f...

Powered by Google App Engine
This is Rietveld 408576698