Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2729543002: Rename platform/Widget to platform/FrameViewBase in web. (Closed)

Created:
3 years, 9 months ago by joelhockey
Modified:
3 years, 9 months ago
Reviewers:
haraken, slangley, sashab
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename platform/Widget to platform/FrameViewBase in web. BUG=697351 Review-Url: https://codereview.chromium.org/2729543002 Cr-Commit-Position: refs/heads/master@{#453916} Committed: https://chromium.googlesource.com/chromium/src/+/ef1fe9bcedcee99abce0a73583db086d15631b1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -96 lines) Patch
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 3 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.h View 2 chunks +14 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 9 chunks +32 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/web/WebNode.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 6 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
joelhockey
3 years, 9 months ago (2017-03-01 10:17:46 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-01 10:31:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729543002/1
3 years, 9 months ago (2017-03-01 12:13:01 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 12:18:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ef1fe9bcedcee99abce0a73583db...

Powered by Google App Engine
This is Rietveld 408576698