Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issue 2729523005: HardwareRenderer should use CompositorFrameSinkSupport (Closed)

Created:
3 years, 9 months ago by Saman Sami
Modified:
3 years, 9 months ago
Reviewers:
Fady Samuel, boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

HardwareRenderer should use CompositorFrameSinkSupport This helps us unify the API to display compositor and enable SurfaceReferences. BUG=693902 Review-Url: https://codereview.chromium.org/2729523005 Cr-Commit-Position: refs/heads/master@{#454407} Committed: https://chromium.googlesource.com/chromium/src/+/89cf97b87566b131bfd619f11ece533ce63d8bf3

Patch Set 1 #

Patch Set 2 : c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -29 lines) Patch
M android_webview/browser/hardware_renderer.h View 1 5 chunks +12 lines, -7 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 7 chunks +26 lines, -22 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Saman Sami
PTAL
3 years, 9 months ago (2017-03-02 16:50:25 UTC) #9
Fady Samuel
lgtm
3 years, 9 months ago (2017-03-02 20:26:54 UTC) #12
boliu
lgtm
3 years, 9 months ago (2017-03-02 22:20:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729523005/20001
3 years, 9 months ago (2017-03-02 22:23:12 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 22:31:00 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/89cf97b87566b131bfd619f11ece...

Powered by Google App Engine
This is Rietveld 408576698