Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2729503007: Remove Profile usage from //apps (Closed)

Created:
3 years, 9 months ago by michaelpg
Modified:
3 years, 8 months ago
Reviewers:
xiyuan, benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, tfarina, achuith+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Profile usage from //apps Excludes tests. BUG=679971 R=benwells@chromium.org,xiyuan@chromium.org TBR=sky@chromium.org # chrome/browser/ui/startup rename Review-Url: https://codereview.chromium.org/2729503007 Cr-Commit-Position: refs/heads/master@{#461609} Committed: https://chromium.googlesource.com/chromium/src/+/4d80e56ccda893a12d9ef7c27547b7586ce582cf

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Patch Set 4 : revert testing_profile dep #

Patch Set 5 : fix oopses #

Patch Set 6 : try mac fixes #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -215 lines) Patch
M apps/DEPS View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
M apps/app_lifetime_monitor.h View 3 chunks +13 lines, -8 lines 0 comments Download
M apps/app_lifetime_monitor.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M apps/app_lifetime_monitor_factory.h View 2 chunks +8 lines, -5 lines 0 comments Download
M apps/app_lifetime_monitor_factory.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M apps/app_load_service.h View 1 4 chunks +6 lines, -4 lines 0 comments Download
M apps/app_load_service.cc View 1 7 chunks +18 lines, -20 lines 0 comments Download
M apps/app_load_service_factory.h View 2 chunks +4 lines, -2 lines 0 comments Download
M apps/app_load_service_factory.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M apps/app_restore_service.h View 4 chunks +14 lines, -8 lines 0 comments Download
M apps/app_restore_service.cc View 1 2 3 4 7 chunks +20 lines, -20 lines 0 comments Download
M apps/app_restore_service_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M apps/app_restore_service_factory.h View 2 chunks +8 lines, -4 lines 0 comments Download
M apps/app_restore_service_factory.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M apps/launcher.h View 7 chunks +14 lines, -10 lines 0 comments Download
M apps/launcher.cc View 9 chunks +41 lines, -40 lines 0 comments Download
M apps/saved_files_service.h View 3 chunks +7 lines, -4 lines 0 comments Download
M apps/saved_files_service.cc View 1 11 chunks +15 lines, -14 lines 0 comments Download
M apps/saved_files_service_factory.h View 3 chunks +6 lines, -3 lines 0 comments Download
M apps/saved_files_service_factory.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm View 1 2 3 4 5 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h View 1 2 3 4 5 6 4 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc View 1 2 3 4 5 8 chunks +17 lines, -13 lines 0 comments Download
M chrome/browser/apps/app_shim/extension_app_shim_handler_mac_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_shim/test/app_shim_host_manager_test_api_mac.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/short_lived_user_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/short_lived_user_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/note_taking_helper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/note_taking_helper_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
michaelpg
PTAL at a fairly straightforward find-and-replace.
3 years, 8 months ago (2017-04-03 22:11:51 UTC) #7
michaelpg
Forgot I needed two reviewers for this: xiyuan: chrome/browser/chromeos/**/* chrome/browser/signin/* benwells: apps/* chrome/browser/apps/app_shim/**/* chrome/browser/extensions/extension_system_impl.cc Thanks!
3 years, 8 months ago (2017-04-03 22:14:00 UTC) #9
xiyuan
lgtm chrome/browser/chromeos/**/* chrome/browser/signin/*
3 years, 8 months ago (2017-04-03 22:43:10 UTC) #10
benwells
lgtm, thanks!
3 years, 8 months ago (2017-04-04 00:59:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729503007/160001
3 years, 8 months ago (2017-04-04 01:00:42 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 01:49:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/4d80e56ccda893a12d9ef7c27547...

Powered by Google App Engine
This is Rietveld 408576698