file_browser_handler/ -> remove linked_ptr usage.

file_browser_handler/ -> remove linked_ptr usage.

BUG=556939
Test=None, internal cleanup.

Review-Url: https://codereview.chromium.org/2729503003
Cr-Commit-Position: refs/heads/master@{#454495}
Committed: https://chromium.googlesource.com/chromium/src/+/3a365a49e0655ab5efddbe6ec8cc9ae4d792685c

[lazyboy, 2017-03-02 03:08:44]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[lazyboy, 2017-03-02 03:08:55]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 03:10:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 04:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 04:10:46]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-03-02 16:04:10]

lgtm.

Side note (unrelated to the changes in this CL): The fact that we have
FileBrowserHandler::List and FileBrowserHandlerList as different types makes me
sad.

https://codereview.chromium.org/2729503003/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc
(right):

https://codereview.chromium.org/2729503003/diff/20001/chrome/common/extension...
chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc:153:
return std::unique_ptr<FileBrowserHandler>();
does return nullptr work?

[lazyboy, 2017-03-03 02:35:25]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 02:35:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lazyboy, 2017-03-03 02:40:38]

https://codereview.chromium.org/2729503003/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc
(right):

https://codereview.chromium.org/2729503003/diff/20001/chrome/common/extension...
chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc:153:
return std::unique_ptr<FileBrowserHandler>();
On 2017/03/02 16:04:10, Devlin wrote:
> does return nullptr work?

Yes, thanks!

[commit-bot: I haz the power, 2017-03-03 03:04:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 03:04:31]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2017-03-03 03:12:13]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2017-03-03 03:12:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2729503003/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2017-03-03 03:12:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 03:17:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488510733135800,
"parent_rev": "a9edbc7f8483a52d2ec12e351c4ba1ee07414ab5", "commit_rev":
"3a365a49e0655ab5efddbe6ec8cc9ae4d792685c"}

[commit-bot: I haz the power, 2017-03-03 03:17:45]

Description was changed from

==========
file_browser_handler/ -> remove linked_ptr usage.

BUG=556939
Test=None, internal cleanup.
==========

to

==========
file_browser_handler/ -> remove linked_ptr usage.

BUG=556939
Test=None, internal cleanup.

Review-Url: https://codereview.chromium.org/2729503003
Cr-Commit-Position: refs/heads/master@{#454495}
Committed:
https://chromium.googlesource.com/chromium/src/+/3a365a49e0655ab5efddbe6ec8cc...
==========

[commit-bot: I haz the power, 2017-03-03 03:17:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3a365a49e0655ab5efddbe6ec8cc...