Update Android site settings to display BLOCK for embargoed permissions.

Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

A consequence of this change is that the GeolocationHeader tests began
failing. This is because the implementation would fall back to querying
for HTTP permission if HTTPS permission was ASK or not available.
Since WebsitePreferenceBridge now queries the PermissionManager,
geolocation permission is automatically blocked over non-HTTPS
connections; it previously directly queried the HostContentSettingsMap.
The code implementing the fallback and related comments have been
removed as geolocation has been restricted to HTTPS origins since Chrome
50.

Additionally, the preferences search engine test fails because it tries
to check geolocation access for http://aol.com. That test is updated to
use a different search engine for that part of the test (one that is
available over HTTPS).

BUG=679877
Review-Url: https://codereview.chromium.org/2729493004
Cr-Commit-Position: refs/heads/master@{#454456}
Committed: https://chromium.googlesource.com/chromium/src/+/42dc98ada07c2bcd71a992aa289147dcc83f9881

[dominickn, 2017-03-02 06:49:44]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 06:50:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-03-02 06:50:56]

dominickn@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[dominickn, 2017-03-02 06:50:56]

Hey Dan, do you mind taking a look at this? Thanks!

[dominickn, 2017-03-02 06:51:36]

Description was changed from

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
they are dismissed too many times, or if they are blacklsited by Safe
Browsing. Embargo is stored on a separate content settings type to avoid
polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

BUG=679877
==========

to

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

BUG=679877
==========

[commit-bot: I haz the power, 2017-03-02 09:03:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 09:03:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dominickn, 2017-03-02 12:34:16]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 12:34:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-03-02 12:39:28]

Description was changed from

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

BUG=679877
==========

to

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

A consequence of this change is that the GeolocationHeader tests began
failing. This is because the implementation would fall back to querying
for HTTP permission if HTTPS permission was ASK or not available.
Since WebsitePreferenceBridge now queries the PermissionManager,
geolocation permission is automatically blocked over non-HTTPS
connections. The code implementing the fallback and related comments
have been removed.

BUG=679877
==========

[dominickn, 2017-03-02 12:43:36]

Description was changed from

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

A consequence of this change is that the GeolocationHeader tests began
failing. This is because the implementation would fall back to querying
for HTTP permission if HTTPS permission was ASK or not available.
Since WebsitePreferenceBridge now queries the PermissionManager,
geolocation permission is automatically blocked over non-HTTPS
connections. The code implementing the fallback and related comments
have been removed.

BUG=679877
==========

to

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

A consequence of this change is that the GeolocationHeader tests began
failing. This is because the implementation would fall back to querying
for HTTP permission if HTTPS permission was ASK or not available.
Since WebsitePreferenceBridge now queries the PermissionManager,
geolocation permission is automatically blocked over non-HTTPS
connections. The code implementing the fallback and related comments
have been removed as geolocation has been restricted to HTTPS origins
since Chrome 50.

BUG=679877
==========

[dominickn, 2017-03-02 12:49:18]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 12:49:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-03-02 12:50:11]

Description was changed from

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

A consequence of this change is that the GeolocationHeader tests began
failing. This is because the implementation would fall back to querying
for HTTP permission if HTTPS permission was ASK or not available.
Since WebsitePreferenceBridge now queries the PermissionManager,
geolocation permission is automatically blocked over non-HTTPS
connections. The code implementing the fallback and related comments
have been removed as geolocation has been restricted to HTTPS origins
since Chrome 50.

BUG=679877
==========

to

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

A consequence of this change is that the GeolocationHeader tests began
failing. This is because the implementation would fall back to querying
for HTTP permission if HTTPS permission was ASK or not available.
Since WebsitePreferenceBridge now queries the PermissionManager,
geolocation permission is automatically blocked over non-HTTPS
connections; it previously directly queried the HostContentSettingsMap.
The code implementing the fallback and related comments have been
removed as geolocation has been restricted to HTTPS origins since Chrome
50.

BUG=679877
==========

[commit-bot: I haz the power, 2017-03-02 14:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 14:23:39]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gone, 2017-03-02 17:05:26]

lgtm

https://codereview.chromium.org/2729493004/diff/1/chrome/browser/android/pref...
File chrome/browser/android/preferences/website_preference_bridge.cc (right):

https://codereview.chromium.org/2729493004/diff/1/chrome/browser/android/pref...
chrome/browser/android/preferences/website_preference_bridge.cc:162:
PermissionDecisionAutoBlocker* autoblocker =
auto_blocker?

https://codereview.chromium.org/2729493004/diff/40001/chrome/browser/android/...
File chrome/browser/android/preferences/website_preference_bridge.cc (right):

https://codereview.chromium.org/2729493004/diff/40001/chrome/browser/android/...
chrome/browser/android/preferences/website_preference_bridge.cc:162:
PermissionDecisionAutoBlocker* autoblocker =
auto_blocker, given AutoBlocker

https://codereview.chromium.org/2729493004/diff/40001/chrome/browser/android/...
chrome/browser/android/preferences/website_preference_bridge.cc:165:
ScopedJavaLocalRef<jstring> jembedder;
could you be clearer about this being an empty embedder?

[dominickn, 2017-03-02 22:53:38]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 22:54:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-03-02 22:54:37]

Description was changed from

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

A consequence of this change is that the GeolocationHeader tests began
failing. This is because the implementation would fall back to querying
for HTTP permission if HTTPS permission was ASK or not available.
Since WebsitePreferenceBridge now queries the PermissionManager,
geolocation permission is automatically blocked over non-HTTPS
connections; it previously directly queried the HostContentSettingsMap.
The code implementing the fallback and related comments have been
removed as geolocation has been restricted to HTTPS origins since Chrome
50.

BUG=679877
==========

to

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

A consequence of this change is that the GeolocationHeader tests began
failing. This is because the implementation would fall back to querying
for HTTP permission if HTTPS permission was ASK or not available.
Since WebsitePreferenceBridge now queries the PermissionManager,
geolocation permission is automatically blocked over non-HTTPS
connections; it previously directly queried the HostContentSettingsMap.
The code implementing the fallback and related comments have been
removed as geolocation has been restricted to HTTPS origins since Chrome
50.

Additionally, the preferences search engine test fails because it tries
to check geolocation access for http://aol.com. That test is updated to
use a different search engine for that part of the test (one that is
available over HTTPS).

BUG=679877
==========

[commit-bot: I haz the power, 2017-03-02 23:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 23:36:23]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-03-02 23:37:53]

PTAL - had to fix another dodgy test. Thanks!

https://codereview.chromium.org/2729493004/diff/40001/chrome/browser/android/...
File chrome/browser/android/preferences/website_preference_bridge.cc (right):

https://codereview.chromium.org/2729493004/diff/40001/chrome/browser/android/...
chrome/browser/android/preferences/website_preference_bridge.cc:162:
PermissionDecisionAutoBlocker* autoblocker =
On 2017/03/02 17:05:26, dfalcantara (load balance plz) wrote:
> auto_blocker, given AutoBlocker

Done.

https://codereview.chromium.org/2729493004/diff/40001/chrome/browser/android/...
chrome/browser/android/preferences/website_preference_bridge.cc:165:
ScopedJavaLocalRef<jstring> jembedder;
On 2017/03/02 17:05:26, dfalcantara (load balance plz) wrote:
> could you be clearer about this being an empty embedder?

Done.

[gone, 2017-03-03 00:15:54]

lgtm

[dominickn, 2017-03-03 00:31:23]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-03-03 00:32:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 01:35:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488501083828930,
"parent_rev": "54e4fbdde6ae7aa7844a0d11489ba76c9f859afb", "commit_rev":
"42dc98ada07c2bcd71a992aa289147dcc83f9881"}

[commit-bot: I haz the power, 2017-03-03 01:37:45]

Description was changed from

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

A consequence of this change is that the GeolocationHeader tests began
failing. This is because the implementation would fall back to querying
for HTTP permission if HTTPS permission was ASK or not available.
Since WebsitePreferenceBridge now queries the PermissionManager,
geolocation permission is automatically blocked over non-HTTPS
connections; it previously directly queried the HostContentSettingsMap.
The code implementing the fallback and related comments have been
removed as geolocation has been restricted to HTTPS origins since Chrome
50.

Additionally, the preferences search engine test fails because it tries
to check geolocation access for http://aol.com. That test is updated to
use a different search engine for that part of the test (one that is
available over HTTPS).

BUG=679877
==========

to

==========
Update Android site settings to display BLOCK for embargoed permissions.

The permissions team has introduced a new temporary block state for
permissions called embargo. Origins may be placed under this state if
their prompts are dismissed too many times, or if they are blacklsited by
Safe Browsing. Embargo is stored on a separate content settings type to
avoid polluting the existing type for each permission.

This CL updates the WebsitePreferenceBridge to query the
PermissionManager and the PERMISSION_AUTOBLOCKER_DATA content settings
type in order to properly display embargoed permissions as blocked in
site settings on Android.

A consequence of this change is that the GeolocationHeader tests began
failing. This is because the implementation would fall back to querying
for HTTP permission if HTTPS permission was ASK or not available.
Since WebsitePreferenceBridge now queries the PermissionManager,
geolocation permission is automatically blocked over non-HTTPS
connections; it previously directly queried the HostContentSettingsMap.
The code implementing the fallback and related comments have been
removed as geolocation has been restricted to HTTPS origins since Chrome
50.

Additionally, the preferences search engine test fails because it tries
to check geolocation access for http://aol.com. That test is updated to
use a different search engine for that part of the test (one that is
available over HTTPS).

BUG=679877

Review-Url: https://codereview.chromium.org/2729493004
Cr-Commit-Position: refs/heads/master@{#454456}
Committed:
https://chromium.googlesource.com/chromium/src/+/42dc98ada07c2bcd71a992aa2891...
==========

[commit-bot: I haz the power, 2017-03-03 01:37:48]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/42dc98ada07c2bcd71a992aa2891...