DescriptionRevert of Polymer: use polymer-css-build --no-inline-includes (patchset #1 id:1 of https://codereview.chromium.org/2718243005/ )
Reason for revert:
Broke Linux ChromeOS version of MD Settings
Original issue's description:
> Polymer: use polymer-css-build --no-inline-includes
>
> Chromium updated polymer-css-build to 1.0.9 to use this feature:
> https://codereview.chromium.org/2714833003
>
> This also required rolling to Polymer 1.8.1 which happened here:
> https://codereview.chromium.org/2717403003
>
> And finally requires a change to Polymer's internal config via:
>
> Polymer.preserveStyleIncludes = true;
>
>
> Given the example DOM:
>
> <dom-module id="css-module">
> <template>
> <style>
> /* module styles */
> </style>
> </template>
> </dom-module>
>
> <dom-module id="my-element">
> <template>
> <style include="css-module">
> /* template styles */
> </style>
> </template>
> </dom-module>
>
> before this patch is combined both at compile time and at runtime into:
>
> <my-element>
> #shadow
> <style>
> /* module styles */
> /* template styles */
> </style>
> </my-element>
>
> This defeats blink's CSS SheetContents caching and inlines many
> duplicate styles into the output (settings ends up at like 1MB of
> HTML/CSS combined before gzip).
>
> With --no-inline-includes, the generated output is significantly smaller
> (65% before compression, ~15% after compression) and include="" modules
> are cloned dynamically at runtime via Node#cloneNode().
>
> The end results (in the DOM) are basically:
>
> <my-element>
> #shadow
> <style>
> /* module styles */
> </style>
> <style>
> /* template style */
> </style>
> </my-element>
>
> I also verified locally that many more <style> tags are bypassing
> parsing and being used from the cache.
>
> R=dpapad@chromium.org
> BUG=597347
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2718243005
> Cr-Commit-Position: refs/heads/master@{#453652}
> Committed: https://chromium.googlesource.com/chromium/src/+/b64500afce5b9342dba43f53f445c12a0ffc57e2
TBR=dpapad@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=597347
Review-Url: https://codereview.chromium.org/2729483002
Cr-Commit-Position: refs/heads/master@{#453840}
Committed: https://chromium.googlesource.com/chromium/src/+/055e9b912a667a19f4d8420b755fec9c7190302b
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|