libwebp: cherry-pick lossless incremental decoding fix

libwebp: port lossless incremental decoding fix

f8fad4fa lossless incremental decoding: fix missing eos_ test

use if (br->eos_) break; as this snapshot does not contain:
16be192f VP8LSetBitPos: remove the eos_ setting

original commit message:

The patch  21735e0 introduced a bug where a goto path was not testing
the eos_ state.  If this happened just before a row_sync, a SaveState()
would be called that would store the eos_ state as '1' till the end
of the loop.  This usually was not a problem, except for the very last
chunk where we disable the incremental decoding altogether (we have all
the data). The termination tests were then going wrong.
The fix is to add a proper eos_ test and avoid falling in this inconsistent
state.

(https://chromium.googlesource.com/webm/libwebp/+/21735e06f7c1cb35562754e7f54365f24124ef15)

BUG=webp:332
Review-Url: https://codereview.chromium.org/2729473002
Cr-Commit-Position: refs/heads/master@{#455989}
Committed: https://chromium.googlesource.com/chromium/src/+/add860c481edc82fa704ea09341942680cdd0e4a

[jzern, 2017-03-01 04:08:02]

Description was changed from

==========
libwebp: cherry-pick lossless incremental decoding fix

f8fad4fa lossless incremental decoding: fix missing eos_ test

lossless incremental decoding: fix missing eos_ test

original commit message:

The patch  21735e0 introduced a bug where a goto path was not testing
the eos_ state.  If this happened just before a row_sync, a SaveState()
would be called that would store the eos_ state as '1' till the end
of the loop.  This usually was not a problem, except for the very last
chunk where we disable the incremental decoding altogether (we have all
the data). The termination tests were then going wrong.
The fix is to add a proper eos_ test and avoid falling in this inconsistent
state.

(https://chromium.googlesource.com/webm/libwebp/+/21735e06f7c1cb35562754e7f543...)

BUG=webp:332
==========

to

==========
libwebp: cherry-pick lossless incremental decoding fix

f8fad4fa lossless incremental decoding: fix missing eos_ test

lossless incremental decoding: fix missing eos_ test

original commit message:

The patch  21735e0 introduced a bug where a goto path was not testing
the eos_ state.  If this happened just before a row_sync, a SaveState()
would be called that would store the eos_ state as '1' till the end
of the loop.  This usually was not a problem, except for the very last
chunk where we disable the incremental decoding altogether (we have all
the data). The termination tests were then going wrong.
The fix is to add a proper eos_ test and avoid falling in this inconsistent
state.

(https://chromium.googlesource.com/webm/libwebp/+/21735e06f7c1cb35562754e7f543...)

BUG=webp:332
==========

[jzern, 2017-03-01 04:08:02]

jzern@chromium.org changed reviewers:
+ urvang@chromium.org

[jzern, 2017-03-01 04:08:10]

The CQ bit was checked by jzern@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 04:08:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 05:49:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 05:49:29]

Dry run: This issue passed the CQ dry run.

[jzern, 2017-03-01 07:29:28]

Description was changed from

==========
libwebp: cherry-pick lossless incremental decoding fix

f8fad4fa lossless incremental decoding: fix missing eos_ test

lossless incremental decoding: fix missing eos_ test

original commit message:

The patch  21735e0 introduced a bug where a goto path was not testing
the eos_ state.  If this happened just before a row_sync, a SaveState()
would be called that would store the eos_ state as '1' till the end
of the loop.  This usually was not a problem, except for the very last
chunk where we disable the incremental decoding altogether (we have all
the data). The termination tests were then going wrong.
The fix is to add a proper eos_ test and avoid falling in this inconsistent
state.

(https://chromium.googlesource.com/webm/libwebp/+/21735e06f7c1cb35562754e7f543...)

BUG=webp:332
==========

to

==========
libwebp: port lossless incremental decoding fix

f8fad4fa lossless incremental decoding: fix missing eos_ test

use if (br->eos_) break; as this snapshot does not contain:
16be192f VP8LSetBitPos: remove the eos_ setting

original commit message:

The patch  21735e0 introduced a bug where a goto path was not testing
the eos_ state.  If this happened just before a row_sync, a SaveState()
would be called that would store the eos_ state as '1' till the end
of the loop.  This usually was not a problem, except for the very last
chunk where we disable the incremental decoding altogether (we have all
the data). The termination tests were then going wrong.
The fix is to add a proper eos_ test and avoid falling in this inconsistent
state.

(https://chromium.googlesource.com/webm/libwebp/+/21735e06f7c1cb35562754e7f543...)

BUG=webp:332
==========

[urvang, 2017-03-03 00:03:52]

lgtm

[jzern, 2017-03-07 00:57:05]

On 2017/03/03 00:03:52, urvang wrote:
> lgtm

submitting now that we're past the m58 branch

[jzern, 2017-03-07 00:57:08]

The CQ bit was checked by jzern@chromium.org

[commit-bot: I haz the power, 2017-03-07 00:58:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 03:58:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 03:58:20]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jzern, 2017-03-07 04:48:47]

On 2017/03/07 03:58:20, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Looks like a flake. I'll retry once then rebase.

[jzern, 2017-03-07 04:48:51]

The CQ bit was checked by jzern@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:49:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 07:16:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:16:37]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jzern, 2017-03-08 00:11:25]

The CQ bit was checked by jzern@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:12:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 02:40:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 02:40:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jzern, 2017-03-08 02:56:16]

The CQ bit was checked by jzern@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 02:56:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 03:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:41:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jzern, 2017-03-08 03:53:12]

The CQ bit was checked by jzern@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 03:53:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 04:16:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 04:16:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jzern, 2017-03-09 23:58:21]

The CQ bit was checked by jzern@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 23:59:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 01:25:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 01:25:53]

Dry run: This issue passed the CQ dry run.

[jzern, 2017-03-10 03:46:32]

The CQ bit was checked by jzern@chromium.org

[jzern, 2017-03-10 03:46:32]

The patchset sent to the CQ was uploaded after l-g-t-m from urvang@chromium.org
Link to the patchset: https://codereview.chromium.org/2729473002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-10 03:46:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 04:15:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489117592088670,
"parent_rev": "b1575e90e984d8aea66570d07b7126034e9a7b8c", "commit_rev":
"add860c481edc82fa704ea09341942680cdd0e4a"}

[commit-bot: I haz the power, 2017-03-10 04:16:35]

Description was changed from

==========
libwebp: port lossless incremental decoding fix

f8fad4fa lossless incremental decoding: fix missing eos_ test

use if (br->eos_) break; as this snapshot does not contain:
16be192f VP8LSetBitPos: remove the eos_ setting

original commit message:

The patch  21735e0 introduced a bug where a goto path was not testing
the eos_ state.  If this happened just before a row_sync, a SaveState()
would be called that would store the eos_ state as '1' till the end
of the loop.  This usually was not a problem, except for the very last
chunk where we disable the incremental decoding altogether (we have all
the data). The termination tests were then going wrong.
The fix is to add a proper eos_ test and avoid falling in this inconsistent
state.

(https://chromium.googlesource.com/webm/libwebp/+/21735e06f7c1cb35562754e7f543...)

BUG=webp:332
==========

to

==========
libwebp: port lossless incremental decoding fix

f8fad4fa lossless incremental decoding: fix missing eos_ test

use if (br->eos_) break; as this snapshot does not contain:
16be192f VP8LSetBitPos: remove the eos_ setting

original commit message:

The patch  21735e0 introduced a bug where a goto path was not testing
the eos_ state.  If this happened just before a row_sync, a SaveState()
would be called that would store the eos_ state as '1' till the end
of the loop.  This usually was not a problem, except for the very last
chunk where we disable the incremental decoding altogether (we have all
the data). The termination tests were then going wrong.
The fix is to add a proper eos_ test and avoid falling in this inconsistent
state.

(https://chromium.googlesource.com/webm/libwebp/+/21735e06f7c1cb35562754e7f543...)

BUG=webp:332

Review-Url: https://codereview.chromium.org/2729473002
Cr-Commit-Position: refs/heads/master@{#455989}
Committed:
https://chromium.googlesource.com/chromium/src/+/add860c481edc82fa704ea093419...
==========

[commit-bot: I haz the power, 2017-03-10 04:16:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/add860c481edc82fa704ea093419...