Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2729453002: Revert of Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)

Created:
3 years, 9 months ago by nainar
Modified:
3 years, 9 months ago
Reviewers:
dstockwell, esprehn, rune
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, meade_UTC10, Mike Lawther (Google), rwlbuis, shans, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Call Element::rebuildLayoutTree from Document::updateStyle directly (patchset #33 id:640001 of https://codereview.chromium.org/2473743003/ ) Reason for revert: Reason for revert is: https://bugs.chromium.org/p/chromium/issues/detail?id=695950 Original issue's description: > Call Element::rebuildLayoutTree from Document::updateStyle directly > > This patch changes the callstack in Document::updateStyle to call > Element::rebuildLayoutTree after Element::recalcStyle instead of > from it. > > It also adds helper functions needed to perform Layout Tree Construction: > 1. ContainerNode::rebuildDescendantLayoutTree() > 2. Element::rebuildShadowRootLayoutTree() > 3. Element::reattachPseudoElementLayoutTree(PseudoId pseudoId) > 4. ShadowRoot::rebuildLayoutTree() > > It also changes the setting/getting of the (Child)NeedsStyleRecalc > and (Child)NeedsReattachLayoutTree bits to match this pattern. > > BUG=595137 > > Review-Url: https://codereview.chromium.org/2473743003 > Cr-Commit-Position: refs/heads/master@{#451987} > Committed: https://chromium.googlesource.com/chromium/src/+/8b6c7b7ce5a36d8eda49dd6e60c5e7c8f5c7277f TBR=esprehn@chromium.org,rune@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=595137 Review-Url: https://codereview.chromium.org/2729453002 Cr-Commit-Position: refs/heads/master@{#453853} Committed: https://chromium.googlesource.com/chromium/src/+/7ff96ffaec996e51a13ac4b9f026d96f81910348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -152 lines) Patch
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp View 3 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 3 chunks +3 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 4 chunks +35 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 4 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +7 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/stylerecalc.md View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
nainar
Created Revert of Call Element::rebuildLayoutTree from Document::updateStyle directly
3 years, 9 months ago (2017-03-01 03:39:57 UTC) #2
dstockwell
lgtm
3 years, 9 months ago (2017-03-01 03:40:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729453002/1
3 years, 9 months ago (2017-03-01 03:40:25 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 05:23:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7ff96ffaec996e51a13ac4b9f026...

Powered by Google App Engine
This is Rietveld 408576698