Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2729433004: Roll DEPS for cros_system_api changes to UpdateEngine DBus API. (Closed)

Created:
3 years, 9 months ago by kumarniranjan
Modified:
3 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll DEPS for cros_system_api changes to UpdateEngine DBus API. BUG=640721 TEST=none Review-Url: https://codereview.chromium.org/2729433004 Cr-Commit-Position: refs/heads/master@{#454332} Committed: https://chromium.googlesource.com/chromium/src/+/24eccbeb16b71a0a1eaae619f2d2d336b2ec9b90

Patch Set 1 #

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
kumarniranjan
3 years, 9 months ago (2017-03-01 23:53:10 UTC) #2
stevenjb
Please include 'cros_system_api' in the Subject (and first line of the description), e.g. Roll DEPS ...
3 years, 9 months ago (2017-03-02 00:12:20 UTC) #3
kumarniranjan
On 2017/03/02 00:12:20, stevenjb wrote: > Please include 'cros_system_api' in the Subject (and first line ...
3 years, 9 months ago (2017-03-02 00:33:37 UTC) #5
stevenjb
I went ahead and changed the Subject for you also since it let me. lgtm
3 years, 9 months ago (2017-03-02 00:51:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729433004/20001
3 years, 9 months ago (2017-03-02 17:46:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/243221)
3 years, 9 months ago (2017-03-02 18:34:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729433004/20001
3 years, 9 months ago (2017-03-02 18:40:23 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 19:22:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/24eccbeb16b71a0a1eaae619f2d2...

Powered by Google App Engine
This is Rietveld 408576698