Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2729383003:
Add blink_perf.editing
DescriptionAdd blink_perf.editing
This CL adds performance tests of Blink Editing:
https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/Editing/
BUG=698661
Patch Set 1 #Patch Set 2 : update #
Created: 3 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 15 (5 generated)
Description was changed from ========== Add blink_perf.editing BUG= ========== to ========== Add blink_perf.editing This CL adds performance tests of Blink Editing: https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/Edit... BUG= ==========
yoichio@chromium.org changed reviewers: + sullivan@chromium.org, tkent@chromium.org, yosin@chromium.org
lgtm Thanks!
I need to update json files for bot with script but it changes so much: $ python tools\perf\generate_perf_json.py Presubmit checks passed. testing/buildbot/chromium.perf.fyi.json | 68147 +++--- testing/buildbot/chromium.perf.json | 363338 +++++++++++++++-------------- tools/perf/benchmarks/blink_perf.py | 3 + 3 files changed, 216287 insertions(+), 215201 deletions(-) Upload server: https://codereview.chromium.org (change with -s/--server) Patch is large, so uploading file patches separately. Issue created. URL: https://codereview.chromium.org/2729383003 (patchset: 1) Not uploading the patch for testing/buildbot/chromium.perf.fyi.json because the file is too large. Not uploading the patch for testing/buildbot/chromium.perf.json because the file is too large. Uploaded patch for tools/perf/benchmarks/blink_perf.py Uploading base file for tools/perf/benchmarks/blink_perf.py I can't upload their diff. sullivan, do you know the best practice?
Description was changed from ========== Add blink_perf.editing This CL adds performance tests of Blink Editing: https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/Edit... BUG= ========== to ========== Add blink_perf.editing This CL adds performance tests of Blink Editing: https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/Edit... BUG=698661 ==========
sullivan@chromium.org changed reviewers: + nednguyen@google.com - sullivan@chromium.org
Ping, Ned. Please read my previous comment and let me know how to upload the huge CL.
On 2017/03/08 06:10:09, yoichio wrote: > Ping, Ned. > Please read my previous comment and let me know how to upload the huge CL. who should we put as owner for this benchmark?
On 2017/03/08 06:13:56, nednguyen wrote: > On 2017/03/08 06:10:09, yoichio wrote: > > Ping, Ned. > > Please read my previous comment and let me know how to upload the huge CL. > > who should we put as owner for this benchmark? It is me(yoichio@chromium.org)
nednguyen@google.com changed reviewers: + martiniss@chromium.org
On 2017/03/08 06:15:50, yoichio wrote: > On 2017/03/08 06:13:56, nednguyen wrote: > > On 2017/03/08 06:10:09, yoichio wrote: > > > Ping, Ned. > > > Please read my previous comment and let me know how to upload the huge CL. > > > > who should we put as owner for this benchmark? > > It is mailto:me(yoichio@chromium.org) Using gerrit can fix the big file uploading problem. lgtm overall
On 2017/03/08 06:17:46, nednguyen wrote: > On 2017/03/08 06:15:50, yoichio wrote: > > On 2017/03/08 06:13:56, nednguyen wrote: > > > On 2017/03/08 06:10:09, yoichio wrote: > > > > Ping, Ned. > > > > Please read my previous comment and let me know how to upload the huge CL. > > > > > > who should we put as owner for this benchmark? > > > > It is mailto:me(yoichio@chromium.org) > > Using gerrit can fix the big file uploading problem. > I don't know how to use gerrit. Could you tell me?
On 2017/03/08 at 07:47:29, yoichio wrote: > I don't know how to use gerrit. Could you tell me? Just add --gerrit to |git cl upload| % git cl upload --gerrit |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
