Bit-mask incorrectly removed first-line pseudo bit.

Bit-mask incorrectly removed first-line pseudo bit.

The m_pseudoBits member only contains the 8 bits for the public pseudo
element bits, yet we used a mask to retrieve them. That mask was
incorrectly set to 0x1fe when it should have been 0xff. Anyway, that
mask is unnecessary and removed.

The mask issue caused StylePropagationDiff, returned from
diffPseudoStyles, to be NoChange for pure ::first-line changes. That
NoChange return were the only case which triggered first-line
invalidation properly.

Instead, always check for pseudo style changes in
pseudoStyleCacheIsInvalid. This fixes issue 698451.

The pseudoStyleCacheIsInvalid method has a weird name, has bugs, and
should be put on LayoutObject and called as part of setStyle instead.
That is for follow-up CLs.

R=meade@chromium.org,mstensho@opera.com
BUG=698451
Review-Url: https://codereview.chromium.org/2729373003
Cr-Commit-Position: refs/heads/master@{#454850}
Committed: https://chromium.googlesource.com/chromium/src/+/f193ee6d21e6548ed425746ec80fb71faa7998a5

[rune, 2017-03-06 00:02:53]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 00:03:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-03-06 00:06:15]

ptal

[commit-bot: I haz the power, 2017-03-06 01:18:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 01:19:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[meade_UTC10, 2017-03-06 02:58:29]

This lgtm, but you have a bunch of failing LayoutTests still...

https://codereview.chromium.org/2729373003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/paint/invalidation/first-line-with-first-letter.html
(right):

https://codereview.chromium.org/2729373003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/invalidation/first-line-with-first-letter.html:20:
}));
Nit: I think this should all be 2-indented...

[rune, 2017-03-06 09:51:10]

On 2017/03/06 02:58:29, Eddy wrote:
> This lgtm, but you have a bunch of failing LayoutTests still...

Before my changes, the pseudoCacheIsInvalid was only called for elements with
first-line/first-line-inherited pseudos or elements without any pseudo elements
at all. I had to adapt that to skip all other pseudos to not recalculate other
pseudo styles. I'll move this to another method in a follow-up pseudo as
mentioned in the TODO.

[rune, 2017-03-06 09:51:19]

https://codereview.chromium.org/2729373003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/paint/invalidation/first-line-with-first-letter.html
(right):

https://codereview.chromium.org/2729373003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/invalidation/first-line-with-first-letter.html:20:
}));
On 2017/03/06 02:58:29, Eddy wrote:
> Nit: I think this should all be 2-indented...

Done.

[rune, 2017-03-06 09:52:01]

The CQ bit was checked by rune@opera.com

[rune, 2017-03-06 09:52:01]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2729373003/#ps20001
(title: "Fixed issues.")

[commit-bot: I haz the power, 2017-03-06 09:52:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 11:33:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488793921007850,
"parent_rev": "9b5ea61b97315d1d028f440d6dc7defed009cf66", "commit_rev":
"f193ee6d21e6548ed425746ec80fb71faa7998a5"}

[commit-bot: I haz the power, 2017-03-06 11:34:25]

Description was changed from

==========
Bit-mask incorrectly removed first-line pseudo bit.

The m_pseudoBits member only contains the 8 bits for the public pseudo
element bits, yet we used a mask to retrieve them. That mask was
incorrectly set to 0x1fe when it should have been 0xff. Anyway, that
mask is unnecessary and removed.

The mask issue caused StylePropagationDiff, returned from
diffPseudoStyles, to be NoChange for pure ::first-line changes. That
NoChange return were the only case which triggered first-line
invalidation properly.

Instead, always check for pseudo style changes in
pseudoStyleCacheIsInvalid. This fixes issue 698451.

The pseudoStyleCacheIsInvalid method has a weird name, has bugs, and
should be put on LayoutObject and called as part of setStyle instead.
That is for follow-up CLs.

R=meade@chromium.org,mstensho@opera.com
BUG=698451
==========

to

==========
Bit-mask incorrectly removed first-line pseudo bit.

The m_pseudoBits member only contains the 8 bits for the public pseudo
element bits, yet we used a mask to retrieve them. That mask was
incorrectly set to 0x1fe when it should have been 0xff. Anyway, that
mask is unnecessary and removed.

The mask issue caused StylePropagationDiff, returned from
diffPseudoStyles, to be NoChange for pure ::first-line changes. That
NoChange return were the only case which triggered first-line
invalidation properly.

Instead, always check for pseudo style changes in
pseudoStyleCacheIsInvalid. This fixes issue 698451.

The pseudoStyleCacheIsInvalid method has a weird name, has bugs, and
should be put on LayoutObject and called as part of setStyle instead.
That is for follow-up CLs.

R=meade@chromium.org,mstensho@opera.com
BUG=698451

Review-Url: https://codereview.chromium.org/2729373003
Cr-Commit-Position: refs/heads/master@{#454850}
Committed:
https://chromium.googlesource.com/chromium/src/+/f193ee6d21e6548ed425746ec80f...
==========

[commit-bot: I haz the power, 2017-03-06 11:34:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f193ee6d21e6548ed425746ec80f...