Fix renderers not getting power broadcast messages

Fix renderers not getting power broadcast messages

Switches from a StrongBinding to a BindingSet, otherwise, as soon as the
renderer had finished calling SetClient() the connection was detached
and the PowerMonitorMessageBroadcaster destroyed, because the client did
not maintain the connection.

Instead, we now have a single PowerMonitorMessageBroadcaster that
maintains a set of bound clients, and notifies all of them on power
messages.

R=blundell@chromium.org
BUG=696197
Review-Url: https://codereview.chromium.org/2729293002
Cr-Commit-Position: refs/heads/master@{#454703}
Committed: https://chromium.googlesource.com/chromium/src/+/0471e6079c754e7478a61ac81765cec789f5249a

[scottmg, 2017-03-03 22:28:20]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 22:28:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-03-03 22:29:04]

Description was changed from

==========
Fix renderers not getting power broadcast messages

Switches from a StrongBinding to a BindingSet, otherwise, as soon as the
renderer had called SetClient() the connection was detached. Instead, we
now have a single PowerMonitorMessageBroadcaster that maintains a set of
bound clients, and notifies all of them.

R=blundell@chromium.org
BUG=696197
==========

to

==========
Fix renderers not getting power broadcast messages

Switches from a StrongBinding to a BindingSet, otherwise, as soon as the
renderer had finished calling SetClient() the connection was detached
and the PowerMonitorMessageBroadcaster destroyed, because the client did
not maintain the connection.

Instead, we now have a single PowerMonitorMessageBroadcaster that
maintains a set of bound clients, and notifies all of them on power
messages.

R=blundell@chromium.org
BUG=696197
==========

[scottmg, 2017-03-03 22:30:25]

Does this make sense? AFAIU, BindingSet takes care of invalidating its members
on connection errors, etc. Is that right?

[blundell, 2017-03-03 22:35:31]

lgtm, thanks!

[blundell, 2017-03-03 22:35:57]

On 2017/03/03 22:35:31, blundell wrote:
> lgtm, thanks!

Just for completeness: I assume that you verified the fix locally?

[scottmg, 2017-03-03 22:36:34]

On 2017/03/03 22:35:57, blundell wrote:
> On 2017/03/03 22:35:31, blundell wrote:
> > lgtm, thanks!
> 
> Just for completeness: I assume that you verified the fix locally?

Yeah :) Seems to work correctly now at least per the repro in comment 0 of the
linked bug.

[scottmg, 2017-03-03 22:36:56]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2017-03-03 22:36:59]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2017-03-03 22:37:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 22:43:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 22:43:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Will Harris, 2017-03-03 22:43:51]

services/device/public/interfaces/power_monitor.mojom lgtm

[blundell, 2017-03-03 22:44:45]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2017-03-03 22:45:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 23:13:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488581085365350, "parent_rev":
"b1af4e3cdf231c274171c482909afef916ae8478", "commit_rev":
"0471e6079c754e7478a61ac81765cec789f5249a"}

[commit-bot: I haz the power, 2017-03-03 23:14:02]

Description was changed from

==========
Fix renderers not getting power broadcast messages

Switches from a StrongBinding to a BindingSet, otherwise, as soon as the
renderer had finished calling SetClient() the connection was detached
and the PowerMonitorMessageBroadcaster destroyed, because the client did
not maintain the connection.

Instead, we now have a single PowerMonitorMessageBroadcaster that
maintains a set of bound clients, and notifies all of them on power
messages.

R=blundell@chromium.org
BUG=696197
==========

to

==========
Fix renderers not getting power broadcast messages

Switches from a StrongBinding to a BindingSet, otherwise, as soon as the
renderer had finished calling SetClient() the connection was detached
and the PowerMonitorMessageBroadcaster destroyed, because the client did
not maintain the connection.

Instead, we now have a single PowerMonitorMessageBroadcaster that
maintains a set of bound clients, and notifies all of them on power
messages.

R=blundell@chromium.org
BUG=696197

Review-Url: https://codereview.chromium.org/2729293002
Cr-Commit-Position: refs/heads/master@{#454703}
Committed:
https://chromium.googlesource.com/chromium/src/+/0471e6079c754e7478a61ac81765...
==========

[commit-bot: I haz the power, 2017-03-03 23:14:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0471e6079c754e7478a61ac81765...