net: remove two dns header flags

net: remove two dns header flags

Chromium's dns client do not use these server flags, so
we can remove them now.

BUG=None
TEST=net_unittests
R=juliatuttle@chromium.org,eroman@chromium.org

Review-Url: https://codereview.chromium.org/2729253006
Cr-Commit-Position: refs/heads/master@{#454784}
Committed: https://chromium.googlesource.com/chromium/src/+/321e2120354336b873e63556893355f8116fcd63

[tfarina, 2017-03-03 23:50:55]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 23:51:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 00:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 00:46:10]

Dry run: This issue passed the CQ dry run.

[eroman, 2017-03-04 01:44:15]

eroman@chromium.org changed reviewers:
+ eroman@chromium.org

[eroman, 2017-03-04 01:44:16]

driveby LGTM

https://codereview.chromium.org/2729253006/diff/1/net/dns/dns_protocol.h
File net/dns/dns_protocol.h (right):

https://codereview.chromium.org/2729253006/diff/1/net/dns/dns_protocol.h#newc...
net/dns/dns_protocol.h:143: static const uint16_t kFlagTC = 0x200;  // TrunCated
- server flag.
TrunCated --> Truncated

[tfarina, 2017-03-04 22:20:07]

https://codereview.chromium.org/2729253006/diff/1/net/dns/dns_protocol.h
File net/dns/dns_protocol.h (right):

https://codereview.chromium.org/2729253006/diff/1/net/dns/dns_protocol.h#newc...
net/dns/dns_protocol.h:143: static const uint16_t kFlagTC = 0x200;  // TrunCated
- server flag.
On 2017/03/04 01:44:16, eroman wrote:
> TrunCated --> Truncated

Done. It was to emphasize why it is TC. But I guess any reader can guess that
from "Truncated" as well.

[tfarina, 2017-03-04 22:20:18]

Description was changed from

==========
net: remove two dns header flags

Chromium's dns client do not use these server flags, so
we can remove them now.

BUG=None
TEST=net_unittests
R=juliatuttle@chromium.org
==========

to

==========
net: remove two dns header flags

Chromium's dns client do not use these server flags, so
we can remove them now.

BUG=None
TEST=net_unittests
R=juliatuttle@chromium.org,eroman@chromium.org
==========

[tfarina, 2017-03-04 22:20:24]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2017-03-04 22:20:25]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2729253006/#ps20001
(title: "Truncated")

[commit-bot: I haz the power, 2017-03-04 22:20:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 23:53:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488666024968870,
"parent_rev": "445361c39af42d3d14152f10a2ae9c786d5d0c68", "commit_rev":
"321e2120354336b873e63556893355f8116fcd63"}

[commit-bot: I haz the power, 2017-03-04 23:54:35]

Description was changed from

==========
net: remove two dns header flags

Chromium's dns client do not use these server flags, so
we can remove them now.

BUG=None
TEST=net_unittests
R=juliatuttle@chromium.org,eroman@chromium.org
==========

to

==========
net: remove two dns header flags

Chromium's dns client do not use these server flags, so
we can remove them now.

BUG=None
TEST=net_unittests
R=juliatuttle@chromium.org,eroman@chromium.org

Review-Url: https://codereview.chromium.org/2729253006
Cr-Commit-Position: refs/heads/master@{#454784}
Committed:
https://chromium.googlesource.com/chromium/src/+/321e2120354336b873e635568933...
==========

[commit-bot: I haz the power, 2017-03-04 23:54:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/321e2120354336b873e635568933...