Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2729253005: Fix PlatformAppBrowserTest.AppWindowIframe. (Closed)

Created:
3 years, 9 months ago by ncarter (slow)
Modified:
3 years, 9 months ago
Reviewers:
benwells, alexmos
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PlatformAppBrowserTest.AppWindowIframe. The problem was that the parent RenderFrameHost was receiving an OnCreateChildFrameCall after RenderProcessGone had been triggered, resulting in WebContentsObservers seeing the creation of a RFH with a nonexistant parent. WebContentsObserverSanityChecker caught this inconsistency. The solution is to drop the message when this happens. BUG=620194 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=benwells@chromium.org Review-Url: https://codereview.chromium.org/2729253005 Cr-Commit-Position: refs/heads/master@{#454987} Committed: https://chromium.googlesource.com/chromium/src/+/7a77bacfbf5f0e7eb11cb69c8e2c1f3abd0dd87d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
ncarter (slow)
Alex, please review
3 years, 9 months ago (2017-03-04 00:33:37 UTC) #7
alexmos
LGTM, thanks for fixing this!
3 years, 9 months ago (2017-03-06 20:27:56 UTC) #8
ncarter (slow)
TBR += benwells
3 years, 9 months ago (2017-03-06 21:55:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729253005/1
3 years, 9 months ago (2017-03-06 21:56:41 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7a77bacfbf5f0e7eb11cb69c8e2c1f3abd0dd87d
3 years, 9 months ago (2017-03-06 22:51:35 UTC) #16
benwells
3 years, 9 months ago (2017-03-07 00:46:29 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698