Make LayerTreeImpl::SetCurrentlyScrollingNode use element ids over layer ids

Make LayerTreeImpl::SetCurrentlyScrollingNode use element ids over layer ids

This patch updates LayerTreeImpl::SetCurrentlyScrollingNode to use
element ids instead of layer ids. A TODO has been added to remove
the use of LayerIdByElementId for the scrollbar animation controller
which is a very large patch.

Tests have been updated to have the scroll element ids set.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2729253003
Cr-Commit-Position: refs/heads/master@{#454713}
Committed: https://chromium.googlesource.com/chromium/src/+/c793ec77b26b49928278bb852a7691d36c8f7544

[pdr., 2017-03-03 21:46:14]

Description was changed from

==========
Make LayerTreeImpl::SetCurrentlyScrollingNode use element ids over layer ids

This patch updates LayerTreeImpl::SetCurrentlyScrollingNode to use
element ids instead of layer ids. A TODO has been added to remove
the use of LayerIdByElementId for the scrollbar animation controller
which is a very large patch.

Tests have been updated to have the scroll element ids set.

BUG=693740
==========

to

==========
Make LayerTreeImpl::SetCurrentlyScrollingNode use element ids over layer ids

This patch updates LayerTreeImpl::SetCurrentlyScrollingNode to use
element ids instead of layer ids. A TODO has been added to remove
the use of LayerIdByElementId for the scrollbar animation controller
which is a very large patch.

Tests have been updated to have the scroll element ids set.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[pdr., 2017-03-03 21:46:52]

pdr@chromium.org changed reviewers:
+ ajuma@chromium.org

[pdr., 2017-03-03 21:46:58]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 21:47:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-03-03 21:52:41]

https://codereview.chromium.org/2729253003/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl_unittest.cc (left):

https://codereview.chromium.org/2729253003/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl_unittest.cc:406:
host_impl_->active_tree()->SetElementIdsForTesting();
In writing this patch I did a version using SetElementIdsForTesting everywhere
instead of setting the scrolling layer element ids directly. It's roughly the
same amount of code but I think the approach in this patch will be better
long-term because we only get element ids where we'd expect them (e.g., they are
not set on the scrollbar layers).

[commit-bot: I haz the power, 2017-03-03 22:57:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 22:57:27]

Dry run: This issue passed the CQ dry run.

[ajuma, 2017-03-03 23:39:21]

lgtm

https://codereview.chromium.org/2729253003/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl_unittest.cc (left):

https://codereview.chromium.org/2729253003/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl_unittest.cc:406:
host_impl_->active_tree()->SetElementIdsForTesting();
On 2017/03/03 21:52:41, pdr. wrote:
> In writing this patch I did a version using SetElementIdsForTesting everywhere
> instead of setting the scrolling layer element ids directly. It's roughly the
> same amount of code but I think the approach in this patch will be better
> long-term because we only get element ids where we'd expect them (e.g., they
are
> not set on the scrollbar layers).

Agreed, setting them only where we'd normally expect them seems better.

[pdr., 2017-03-03 23:41:11]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-03-03 23:41:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 23:45:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488584471324320, "parent_rev":
"ec1efa5525f4ebe69fe0fb4dffb06cc4d88c9abb", "commit_rev":
"c793ec77b26b49928278bb852a7691d36c8f7544"}

[commit-bot: I haz the power, 2017-03-03 23:46:14]

Description was changed from

==========
Make LayerTreeImpl::SetCurrentlyScrollingNode use element ids over layer ids

This patch updates LayerTreeImpl::SetCurrentlyScrollingNode to use
element ids instead of layer ids. A TODO has been added to remove
the use of LayerIdByElementId for the scrollbar animation controller
which is a very large patch.

Tests have been updated to have the scroll element ids set.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Make LayerTreeImpl::SetCurrentlyScrollingNode use element ids over layer ids

This patch updates LayerTreeImpl::SetCurrentlyScrollingNode to use
element ids instead of layer ids. A TODO has been added to remove
the use of LayerIdByElementId for the scrollbar animation controller
which is a very large patch.

Tests have been updated to have the scroll element ids set.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2729253003
Cr-Commit-Position: refs/heads/master@{#454713}
Committed:
https://chromium.googlesource.com/chromium/src/+/c793ec77b26b49928278bb852a76...
==========

[commit-bot: I haz the power, 2017-03-03 23:46:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c793ec77b26b49928278bb852a76...