[Android] Fix a custom search engine bounces when it selected and unselected as default engine

[Android] Fix a custom search engine bounces when it selected and unselected as default engine

When there are mutliple custom search engines displayed on setting page,
selecting and unselecting all except the top one will make them bounce
between default list and custom engine list. The right behaivor should
be the selected custom engine should remain in the same place and be
updated next time loading the setting page.

It is caused using their indexes to decide whether two engines are the
same. However, selecting/unselecting a custom engine will make Chrome
reorder the engine list which changes the selected/unselected one's
index and forces Chrome to refresh the list on Android.

To fix it, index of a search engine should not be used to decide whether
two engines are the same.

BUG=692343
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2691033007
Cr-Commit-Position: refs/heads/master@{#451890}
(cherry picked from commit 06aa457920d30616cc4c47c23057714694e3b3a7)

Review-Url: https://codereview.chromium.org/2729253002
Cr-Commit-Position: refs/branch-heads/2987@{#757}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/70335e0880ba8cbe86aad7e3e53965ec23c7c9b2

[ltian, 2017-03-03 20:09:57]

ltian@chromium.org changed reviewers:
+ tedchoc@chromium.org

[ltian, 2017-03-03 20:09:58]

tedchoc@chromium.org: could you help to lgtm this cl?

Thanks!

[Ted C, 2017-03-03 20:10:30]

lgtm

[ltian, 2017-03-03 20:14:05]

The CQ bit was checked by ltian@chromium.org

[commit-bot: I haz the power, 2017-03-03 20:14:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 20:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 20:14:32]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[ltian, 2017-03-03 20:34:35]

Description was changed from

==========
[Android] Fix a custom search engine bounces when it selected and unselected as
default engine

When there are mutliple custom search engines displayed on setting page,
selecting and unselecting all except the top one will make them bounce
between default list and custom engine list. The right behaivor should
be the selected custom engine should remain in the same place and be
updated next time loading the setting page.

It is caused using their indexes to decide whether two engines are the
same. However, selecting/unselecting a custom engine will make Chrome
reorder the engine list which changes the selected/unselected one's
index and forces Chrome to refresh the list on Android.

To fix it, index of a search engine should not be used to decide whether
two engines are the same.

BUG=692343

Review-Url: https://codereview.chromium.org/2691033007
Cr-Commit-Position: refs/heads/master@{#451890}
(cherry picked from commit 06aa457920d30616cc4c47c23057714694e3b3a7)
==========

to

==========
[Android] Fix a custom search engine bounces when it selected and unselected as
default engine

When there are mutliple custom search engines displayed on setting page,
selecting and unselecting all except the top one will make them bounce
between default list and custom engine list. The right behaivor should
be the selected custom engine should remain in the same place and be
updated next time loading the setting page.

It is caused using their indexes to decide whether two engines are the
same. However, selecting/unselecting a custom engine will make Chrome
reorder the engine list which changes the selected/unselected one's
index and forces Chrome to refresh the list on Android.

To fix it, index of a search engine should not be used to decide whether
two engines are the same.

NOTRY=true
NOPRESUBMIT=true

BUG=692343

Review-Url: https://codereview.chromium.org/2691033007
Cr-Commit-Position: refs/heads/master@{#451890}
(cherry picked from commit 06aa457920d30616cc4c47c23057714694e3b3a7)
==========

[ltian, 2017-03-03 20:35:52]

Description was changed from

==========
[Android] Fix a custom search engine bounces when it selected and unselected as
default engine

When there are mutliple custom search engines displayed on setting page,
selecting and unselecting all except the top one will make them bounce
between default list and custom engine list. The right behaivor should
be the selected custom engine should remain in the same place and be
updated next time loading the setting page.

It is caused using their indexes to decide whether two engines are the
same. However, selecting/unselecting a custom engine will make Chrome
reorder the engine list which changes the selected/unselected one's
index and forces Chrome to refresh the list on Android.

To fix it, index of a search engine should not be used to decide whether
two engines are the same.

NOTRY=true
NOPRESUBMIT=true

BUG=692343

Review-Url: https://codereview.chromium.org/2691033007
Cr-Commit-Position: refs/heads/master@{#451890}
(cherry picked from commit 06aa457920d30616cc4c47c23057714694e3b3a7)
==========

to

==========
[Android] Fix a custom search engine bounces when it selected and unselected as
default engine

When there are mutliple custom search engines displayed on setting page,
selecting and unselecting all except the top one will make them bounce
between default list and custom engine list. The right behaivor should
be the selected custom engine should remain in the same place and be
updated next time loading the setting page.

It is caused using their indexes to decide whether two engines are the
same. However, selecting/unselecting a custom engine will make Chrome
reorder the engine list which changes the selected/unselected one's
index and forces Chrome to refresh the list on Android.

To fix it, index of a search engine should not be used to decide whether
two engines are the same.

BUG=692343
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2691033007
Cr-Commit-Position: refs/heads/master@{#451890}
(cherry picked from commit 06aa457920d30616cc4c47c23057714694e3b3a7)
==========

[ltian, 2017-03-03 20:37:26]

The CQ bit was checked by ltian@chromium.org

[ltian, 2017-03-03 20:37:26]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2729253002/#ps20001
(title: "Add NOTRY=true and NOPRESUBMIT=true for commit.")

[commit-bot: I haz the power, 2017-03-03 20:38:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 20:42:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488573446623900,
"parent_rev": "a712551885b2761f50a16fa69395d55406e4b386", "commit_rev":
"70335e0880ba8cbe86aad7e3e53965ec23c7c9b2"}

[commit-bot: I haz the power, 2017-03-03 20:42:48]

Description was changed from

==========
[Android] Fix a custom search engine bounces when it selected and unselected as
default engine

When there are mutliple custom search engines displayed on setting page,
selecting and unselecting all except the top one will make them bounce
between default list and custom engine list. The right behaivor should
be the selected custom engine should remain in the same place and be
updated next time loading the setting page.

It is caused using their indexes to decide whether two engines are the
same. However, selecting/unselecting a custom engine will make Chrome
reorder the engine list which changes the selected/unselected one's
index and forces Chrome to refresh the list on Android.

To fix it, index of a search engine should not be used to decide whether
two engines are the same.

BUG=692343
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2691033007
Cr-Commit-Position: refs/heads/master@{#451890}
(cherry picked from commit 06aa457920d30616cc4c47c23057714694e3b3a7)
==========

to

==========
[Android] Fix a custom search engine bounces when it selected and unselected as
default engine

When there are mutliple custom search engines displayed on setting page,
selecting and unselecting all except the top one will make them bounce
between default list and custom engine list. The right behaivor should
be the selected custom engine should remain in the same place and be
updated next time loading the setting page.

It is caused using their indexes to decide whether two engines are the
same. However, selecting/unselecting a custom engine will make Chrome
reorder the engine list which changes the selected/unselected one's
index and forces Chrome to refresh the list on Android.

To fix it, index of a search engine should not be used to decide whether
two engines are the same.

BUG=692343
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2691033007
Cr-Commit-Position: refs/heads/master@{#451890}
(cherry picked from commit 06aa457920d30616cc4c47c23057714694e3b3a7)

Review-Url: https://codereview.chromium.org/2729253002
Cr-Commit-Position: refs/branch-heads/2987@{#757}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/70335e0880ba8cbe86aad7e3e539...
==========

[commit-bot: I haz the power, 2017-03-03 20:42:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/70335e0880ba8cbe86aad7e3e539...