Fixing flakiness of TextureLayerMailboxIsActivatedDuringCommit

Fixing flakiness of TextureLayerMailboxIsActivatedDuringCommit

BUG=641613, 696203
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2729183002
Cr-Commit-Position: refs/heads/master@{#454599}
Committed: https://chromium.googlesource.com/chromium/src/+/0834fe043155e4fa29304939380d5b90a3ad3658

[Saman Sami, 2017-03-03 16:08:15]

Description was changed from

==========
Fixing flakiness of TextureLayerMailboxIsActivatedDuringCommit

BUG=641613,696203
==========

to

==========
Fixing flakiness of TextureLayerMailboxIsActivatedDuringCommit

BUG=641613,696203
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-03-03 16:08:16]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 16:08:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-03 16:10:26]

samans@chromium.org changed reviewers:
+ danakj@chromium.org

[Saman Sami, 2017-03-03 16:10:27]

danakj@: Can you take a look? The test doesn't flake anymore on my workstation.

[commit-bot: I haz the power, 2017-03-03 16:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 16:25:20]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-03-03 16:33:26]

LGTM

https://codereview.chromium.org/2729183002/diff/1/cc/layers/texture_layer_uni...
File cc/layers/texture_layer_unittest.cc (left):

https://codereview.chromium.org/2729183002/diff/1/cc/layers/texture_layer_uni...
cc/layers/texture_layer_unittest.cc:871: // Flaky on windows and linux.
https://crbug.com/641613
Oooh dang, we let this sit here D:

https://codereview.chromium.org/2729183002/diff/1/cc/layers/texture_layer_uni...
File cc/layers/texture_layer_unittest.cc (right):

https://codereview.chromium.org/2729183002/diff/1/cc/layers/texture_layer_uni...
cc/layers/texture_layer_unittest.cc:882: int activate_count_;
nit: can u init this here too now since you're doing that below? (and i think u
can delete the constructor then?)

[Saman Sami, 2017-03-03 16:43:33]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-03-03 16:43:33]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2729183002/#ps20001
(title: "Removed constrcutor")

[Saman Sami, 2017-03-03 16:43:52]

https://codereview.chromium.org/2729183002/diff/1/cc/layers/texture_layer_uni...
File cc/layers/texture_layer_unittest.cc (right):

https://codereview.chromium.org/2729183002/diff/1/cc/layers/texture_layer_uni...
cc/layers/texture_layer_unittest.cc:882: int activate_count_;
On 2017/03/03 16:33:26, danakj wrote:
> nit: can u init this here too now since you're doing that below? (and i think
u
> can delete the constructor then?)

Done.

[commit-bot: I haz the power, 2017-03-03 16:43:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 17:03:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488559413483260,
"parent_rev": "7b44260f27f6b52b3a1b81e81cdedeb8164b4497", "commit_rev":
"0834fe043155e4fa29304939380d5b90a3ad3658"}

[commit-bot: I haz the power, 2017-03-03 17:04:03]

Description was changed from

==========
Fixing flakiness of TextureLayerMailboxIsActivatedDuringCommit

BUG=641613,696203
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fixing flakiness of TextureLayerMailboxIsActivatedDuringCommit

BUG=641613,696203
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2729183002
Cr-Commit-Position: refs/heads/master@{#454599}
Committed:
https://chromium.googlesource.com/chromium/src/+/0834fe043155e4fa29304939380d...
==========

[commit-bot: I haz the power, 2017-03-03 17:04:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0834fe043155e4fa29304939380d...