Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2729183002: Fixing flakiness of TextureLayerMailboxIsActivatedDuringCommit (Closed)

Created:
3 years, 9 months ago by Saman Sami
Modified:
3 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fixing flakiness of TextureLayerMailboxIsActivatedDuringCommit BUG=641613, 696203 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2729183002 Cr-Commit-Position: refs/heads/master@{#454599} Committed: https://chromium.googlesource.com/chromium/src/+/0834fe043155e4fa29304939380d5b90a3ad3658

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed constrcutor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M cc/layers/texture_layer_unittest.cc View 1 4 chunks +23 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Saman Sami
danakj@: Can you take a look? The test doesn't flake anymore on my workstation.
3 years, 9 months ago (2017-03-03 16:10:27 UTC) #5
danakj
LGTM https://codereview.chromium.org/2729183002/diff/1/cc/layers/texture_layer_unittest.cc File cc/layers/texture_layer_unittest.cc (left): https://codereview.chromium.org/2729183002/diff/1/cc/layers/texture_layer_unittest.cc#oldcode871 cc/layers/texture_layer_unittest.cc:871: // Flaky on windows and linux. https://crbug.com/641613 Oooh ...
3 years, 9 months ago (2017-03-03 16:33:26 UTC) #8
Saman Sami
https://codereview.chromium.org/2729183002/diff/1/cc/layers/texture_layer_unittest.cc File cc/layers/texture_layer_unittest.cc (right): https://codereview.chromium.org/2729183002/diff/1/cc/layers/texture_layer_unittest.cc#newcode882 cc/layers/texture_layer_unittest.cc:882: int activate_count_; On 2017/03/03 16:33:26, danakj wrote: > nit: ...
3 years, 9 months ago (2017-03-03 16:43:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729183002/20001
3 years, 9 months ago (2017-03-03 16:43:56 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 17:04:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0834fe043155e4fa29304939380d...

Powered by Google App Engine
This is Rietveld 408576698