Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2729163002: [turbofan] compute arguments length in deoptimizer (Closed)

Created:
3 years, 9 months ago by Tobias Tebbi
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] compute arguments length in deoptimizer Following the design of https://codereview.chromium.org/2692753004, also compute the arguments length in the deoptimizer sucht that it does not have to be computed in optimized code. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2729163002 Cr-Commit-Position: refs/heads/master@{#43587} Committed: https://chromium.googlesource.com/v8/v8/+/e61ff99104c101a8555c3b9c9232712accaa4ce6

Patch Set 1 #

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -31 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +9 lines, -1 line 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/compiler/instruction.h View 5 chunks +15 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/deoptimizer.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 5 chunks +40 lines, -15 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/arguments-deopt.js View 5 chunks +24 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Tobias Tebbi
I verified it using the modified test-case. What is the name of the Ember function ...
3 years, 9 months ago (2017-03-03 12:19:11 UTC) #1
Benedikt Meurer
LGTM from me (maybe as a follow-up CL we could change the bool on the ...
3 years, 9 months ago (2017-03-03 12:55:14 UTC) #3
Jarin
lgtm
3 years, 9 months ago (2017-03-03 13:11:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729163002/20001
3 years, 9 months ago (2017-03-03 13:16:49 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 13:43:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e61ff99104c101a8555c3b9c9232712acca...

Powered by Google App Engine
This is Rietveld 408576698