Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2729133006: Fix orphaned wpt -expected.txt file deletion logic. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
domenic, jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix orphaned wpt -expected.txt file deletion logic. The previous logic was to use glob to check for corresponding existing tests for a given baseline (-expected.txt) file, but this is incorrect. The corresponding test for a given baseline always involves adding one of a small set of possible extensions. This CL also removes all files that would now be considered orphaned baselines according to the new logic. BUG=687746 Review-Url: https://codereview.chromium.org/2729133006 Cr-Commit-Position: refs/heads/master@{#455017} Committed: https://chromium.googlesource.com/chromium/src/+/10ac6df8184863142d3fa9b60b0349b3d062978a

Patch Set 1 #

Patch Set 2 : Fix orphan baseline deletion logic. #

Patch Set 3 : Remove orphan baselines; remove print line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6273 lines) Patch
D third_party/WebKit/LayoutTests/external/wpt/dom/ranges/Range-mutations-expected.txt View 1 2 1 chunk +0 lines, -6070 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/events/messageevent-constructor-expected.txt View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/credentials-expected.txt View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/byte-length-queuing-strategy.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/count-queuing-strategy.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-backward.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/piping/error-propagation-backward.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/piping/error-propagation-forward.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/piping/flow-control.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/piping/general.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/piping/transform-streams.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-byte-streams/general.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/bad-strategies.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/bad-underlying-sources.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/brand-checks.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/cancel.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/count-queuing-strategy-integration.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/garbage-collection.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/general.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/pipe-through.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/readable-stream-reader.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/tee.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/templated.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-strategies.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/brand-checks.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/byte-length-queuing-strategy.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/count-queuing-strategy.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/general.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/start.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write.serviceworker-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 2 3 chunks +16 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
qyearsley
Hi domenic@, does this change look OK for removing the -expected.txt files left behind in ...
3 years, 9 months ago (2017-03-06 18:37:40 UTC) #7
domenic
On 2017/03/06 at 18:37:40, qyearsley wrote: > Hi domenic@, does this change look OK for ...
3 years, 9 months ago (2017-03-06 20:14:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729133006/40001
3 years, 9 months ago (2017-03-06 21:05:31 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-06 21:05:33 UTC) #12
qyearsley
+jeffcarp as reviewer
3 years, 9 months ago (2017-03-06 21:12:07 UTC) #15
jeffcarp
lgtm
3 years, 9 months ago (2017-03-06 23:40:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729133006/40001
3 years, 9 months ago (2017-03-07 00:10:03 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 01:25:25 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/10ac6df8184863142d3fa9b60b03...

Powered by Google App Engine
This is Rietveld 408576698