Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

ui/views/controls/textfield/textfield.h

Index: ui/views/controls/textfield/textfield.h
diff --git a/ui/views/controls/textfield/textfield.h b/ui/views/controls/textfield/textfield.h
index 4e4fc2e745e515deed03010cca672b16f6374313..cc54705b7aaa4bd0d704d4e712c69f06d2e4c288 100644
--- a/ui/views/controls/textfield/textfield.h
+++ b/ui/views/controls/textfield/textfield.h
@@ -334,7 +334,11 @@ class VIEWS_EXPORT Textfield : public View,
   virtual base::string16 GetSelectionClipboardText() const;
 
   // Executes the given |command|.
-  virtual void ExecuteTextEditCommand(ui::TextEditCommand command);
+  void ExecuteTextEditCommand(ui::TextEditCommand command);
+
+  // Implementation of ExecuteTextEditCommand. It returns true if text or cursor
+  // have changed; otherwise, returns false.
+  virtual bool ExecuteTextEditCommandImpl(ui::TextEditCommand command);

[sky, 2017/03/09 19:31:24]

Having to return whether state is modified by subclasses is error prone,
especially when the textfield maintains its own state and should be able to
detect when it's modified. Additionally having two Execute functions results in
an awkward API. Textfield should be able to detect when the model and/or caret
visibility changes and take appropriate action.

Is the bug that SetCursorEnabled() is a straight callthrough to RenderText when
it potentially needs to update the cursor view?

 
  private:
   friend class TextfieldTestApi;