Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

ui/views/controls/textfield/textfield.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #define UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 316 matching lines @@
 
   // Returns the TextfieldModel's text/cursor/selection rendering model.
   gfx::RenderText* GetRenderText() const;
 
   gfx::Point GetLastClickLocation() const;
 
   // Get the text from the selection clipboard.
   virtual base::string16 GetSelectionClipboardText() const;
 
   // Executes the given |command|.
-  virtual void ExecuteTextEditCommand(ui::TextEditCommand command);
+  void ExecuteTextEditCommand(ui::TextEditCommand command);
+
+  // Implementation of ExecuteTextEditCommand. It returns true if text or cursor
+  // have changed; otherwise, returns false.
+  virtual bool ExecuteTextEditCommandImpl(ui::TextEditCommand command);

[sky, 2017/03/09 19:31:24]

Having to return whether state is modified by subclasses is error prone,
especially when the textfield maintains its own state and should be able to
detect when it's modified. Additionally having two Execute functions results in
an awkward API. Textfield should be able to detect when the model and/or caret
visibility changes and take appropriate action.

Is the bug that SetCursorEnabled() is a straight callthrough to RenderText when
it potentially needs to update the cursor view?

 
  private:
   friend class TextfieldTestApi;
 
   // View overrides:
   // Declared final since overriding by subclasses would interfere with the
   // accounting related to the scheduled text edit command. Subclasses should
   // use TextfieldController::HandleKeyEvent, to intercept the key event.
   bool OnKeyPressed(const ui::KeyEvent& event) final;
   bool OnKeyReleased(const ui::KeyEvent& event) final;
@@ skipping 181 matching lines @@
 
   // Used to bind callback functions to this object.
   base::WeakPtrFactory<Textfield> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Textfield);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_