Mojo C++ bindings: keep connection error handler on the stack while running it.

Mojo C++ bindings: keep connection error handler on the stack while running it.

Otherwise, if the error handler owns the interface endpoint, resetting the interface endpoint in the error handler will destroy the error handler and the interface endpoint it owns, which leads to crash.

BUG=697728
Review-Url: https://codereview.chromium.org/2729133004
Cr-Commit-Position: refs/heads/master@{#454618}
Committed: https://chromium.googlesource.com/chromium/src/+/477d1f7294ce5a7b13ce399ca4da899b667547a5

[yzshen1, 2017-03-03 16:54:34]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 16:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-03-03 16:55:05]

yzshen@chromium.org changed reviewers:
+ blundell@chromium.org

[yzshen1, 2017-03-03 16:55:05]

Hi, Colin.

Would you please take a look? Thanks!

[blundell, 2017-03-03 17:02:16]

lgtm

Could you flesh out the CL description with some of the motivation described in
the bug? Thanks!

[yzshen1, 2017-03-03 17:27:30]

Description was changed from

==========
Mojo C++ bindings: keep connection error handler on the stack while running it.

BUG=697728
==========

to

==========
Mojo C++ bindings: keep connection error handler on the stack while running it.

Otherwise, if the error handler owns the interface endpoint, resetting the
interface endpoint in the error handler will destroy the error handler and the
interface endpoint it owns, which leads to crash.

BUG=697728
==========

[yzshen1, 2017-03-03 17:27:41]

On 2017/03/03 17:02:16, blundell wrote:
> lgtm
> 
> Could you flesh out the CL description with some of the motivation described
in
> the bug? Thanks!

Done. Thanks!

[yzshen1, 2017-03-03 17:27:45]

The CQ bit was unchecked by yzshen@chromium.org

[yzshen1, 2017-03-03 17:27:46]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-03-03 17:27:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 17:52:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488562066244480, "parent_rev":
"5dbd77c73cd8a5f42762c5036a9860bc729dc359", "commit_rev":
"477d1f7294ce5a7b13ce399ca4da899b667547a5"}

[commit-bot: I haz the power, 2017-03-03 17:53:34]

Description was changed from

==========
Mojo C++ bindings: keep connection error handler on the stack while running it.

Otherwise, if the error handler owns the interface endpoint, resetting the
interface endpoint in the error handler will destroy the error handler and the
interface endpoint it owns, which leads to crash.

BUG=697728
==========

to

==========
Mojo C++ bindings: keep connection error handler on the stack while running it.

Otherwise, if the error handler owns the interface endpoint, resetting the
interface endpoint in the error handler will destroy the error handler and the
interface endpoint it owns, which leads to crash.

BUG=697728

Review-Url: https://codereview.chromium.org/2729133004
Cr-Commit-Position: refs/heads/master@{#454618}
Committed:
https://chromium.googlesource.com/chromium/src/+/477d1f7294ce5a7b13ce399ca4da...
==========

[commit-bot: I haz the power, 2017-03-03 17:53:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/477d1f7294ce5a7b13ce399ca4da...