Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2729113002: De-flake fast/text/line-break-8bit-after-16bit.html (Closed)

Created:
3 years, 9 months ago by kojii
Modified:
3 years, 9 months ago
Reviewers:
drott
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

De-flake fast/text/line-break-8bit-after-16bit.html Attempt to de-flake the test by explicitly waiting for the font to load. Uses the same technique as http://crrev.com/2706033008 TBR=drott@chromium.org BUG=694467 Review-Url: https://codereview.chromium.org/2729113002 Cr-Commit-Position: refs/heads/master@{#454538} Committed: https://chromium.googlesource.com/chromium/src/+/5d613c1778d2d91e97a042c71acf24fb17e925ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/line-break-8bit-after-16bit.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/line-break-8bit-after-16bit-expected.html View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
kojii
3 years, 9 months ago (2017-03-03 06:23:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729113002/1
3 years, 9 months ago (2017-03-03 06:23:45 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 07:30:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d613c1778d2d91e97a042c71acf...

Powered by Google App Engine
This is Rietveld 408576698