Fix bug with data:urls and PlzNavigate on Android.

Fix bug with data:urls and PlzNavigate on Android.

data urls always go to the browser on Android so that the application has a chance to handle them (see rr143228). With PlzNavigate, this has already happened for navigation requests so there's no need to send them again to the browser (and it triggers unhandled codepaths if that happens).

This fixes:
org.chromium.content.browser.InterstitialPageTest#testCloseInterstitial
InterstitialPageImplTest.Paste
InterstitialPageImplTest.Cut
DevToolsProtocolTest.InterstitialShownOnAttach
InterstitialPageImplTest.SelectAll
DevToolsProtocolTest.ShowCertificateViewer
InterstitialPageImplTest.Copy
SitePerProcessBrowserTest.NavigateOpenerWithInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkErrorForMaliciousSubresource with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkErrorForMaliciousSubresource
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingMaliciousSubresourceShowsInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkError with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingShowsInterstitialForMalware with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingCanProceedThroughInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingShowsInterstitialForMalware
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingMaliciousSubresourceShowsInterstitial with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkError
org.chromium.android_webview.test.LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted
org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest#testNotCalledForExistingContentUrl with {--webview-sandboxed-renderer}

BUG=673806
Review-Url: https://codereview.chromium.org/2729103005
Cr-Commit-Position: refs/heads/master@{#454883}
Committed: https://chromium.googlesource.com/chromium/src/+/4ff77a6cf88f3a5d793eabb02bd62d61f8dd4b1f

[jam, 2017-03-05 05:09:54]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-05 05:10:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-05 05:33:59]

Description was changed from

==========
test

BUG=
==========

to

==========
Fix bug with data:urls and PlzNavigate on Android.

data urls always go to the browser on Android so that the application has a
chance to handle them (see rr143228). With PlzNavigate, this has already
happened for navigation requests so there's no need to send them again to the
browser (and it triggers unhandled codepaths if that happens).

This fixes:
org.chromium.content.browser.InterstitialPageTest#testCloseInterstitial
InterstitialPageImplTest.Paste
InterstitialPageImplTest.Cut
DevToolsProtocolTest.InterstitialShownOnAttach
InterstitialPageImplTest.SelectAll
DevToolsProtocolTest.ShowCertificateViewer
InterstitialPageImplTest.Copy
SitePerProcessBrowserTest.NavigateOpenerWithInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkErrorForMaliciousSubresource
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkErrorForMaliciousSubresource
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingMaliciousSubresourceShowsInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkError
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingShowsInterstitialForMalware
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingCanProceedThroughInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingShowsInterstitialForMalware
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingMaliciousSubresourceShowsInterstitial
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkError
org.chromium.android_webview.test.LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted
org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest#testNotCalledForExistingContentUrl
with {--webview-sandboxed-renderer}

BUG=673806
==========

[commit-bot: I haz the power, 2017-03-05 05:53:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-05 05:53:54]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-06 04:30:36]

jam@chromium.org changed reviewers:
+ clamy@chromium.org

[jam, 2017-03-06 04:30:45]

Patchset #1 (id:1) has been deleted

[jam, 2017-03-06 04:30:52]

Patchset #1 (id:20001) has been deleted

[clamy, 2017-03-06 14:41:06]

Thanks! One question below.

https://codereview.chromium.org/2729103005/diff/60001/content/child/web_url_l...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/2729103005/diff/60001/content/child/web_url_l...
content/child/web_url_loader_impl.cc:935:
request_.checkForBrowserSideNavigation()) {
Can we really get there with request_.checkForBrowserSideNavigation() being
true? I thought that all renderer-initiated navs to data urls were already sent
to the browser via BeginNavigation.

[jam, 2017-03-06 15:30:10]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 15:30:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-06 16:07:07]

https://codereview.chromium.org/2729103005/diff/60001/content/child/web_url_l...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/2729103005/diff/60001/content/child/web_url_l...
content/child/web_url_loader_impl.cc:935:
request_.checkForBrowserSideNavigation()) {
On 2017/03/06 14:41:06, clamy wrote:
> Can we really get there with request_.checkForBrowserSideNavigation() being
> true? I thought that all renderer-initiated navs to data urls were already
sent
> to the browser via BeginNavigation.

Ah, I had added that second part of the condition in case it could be reached
but you're right it has no effect (confirmed through try run in PS3).

[clamy, 2017-03-06 16:09:14]

Thanks! Lgtm.

[jam, 2017-03-06 16:14:35]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-03-06 16:14:40]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-06 16:15:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 17:47:00]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488816880327250,
"parent_rev": "4c48f1a300005c92a453e7864979b4780c2a9ac7", "commit_rev":
"4ff77a6cf88f3a5d793eabb02bd62d61f8dd4b1f"}

[commit-bot: I haz the power, 2017-03-06 17:47:44]

Description was changed from

==========
Fix bug with data:urls and PlzNavigate on Android.

data urls always go to the browser on Android so that the application has a
chance to handle them (see rr143228). With PlzNavigate, this has already
happened for navigation requests so there's no need to send them again to the
browser (and it triggers unhandled codepaths if that happens).

This fixes:
org.chromium.content.browser.InterstitialPageTest#testCloseInterstitial
InterstitialPageImplTest.Paste
InterstitialPageImplTest.Cut
DevToolsProtocolTest.InterstitialShownOnAttach
InterstitialPageImplTest.SelectAll
DevToolsProtocolTest.ShowCertificateViewer
InterstitialPageImplTest.Copy
SitePerProcessBrowserTest.NavigateOpenerWithInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkErrorForMaliciousSubresource
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkErrorForMaliciousSubresource
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingMaliciousSubresourceShowsInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkError
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingShowsInterstitialForMalware
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingCanProceedThroughInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingShowsInterstitialForMalware
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingMaliciousSubresourceShowsInterstitial
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkError
org.chromium.android_webview.test.LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted
org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest#testNotCalledForExistingContentUrl
with {--webview-sandboxed-renderer}

BUG=673806
==========

to

==========
Fix bug with data:urls and PlzNavigate on Android.

data urls always go to the browser on Android so that the application has a
chance to handle them (see rr143228). With PlzNavigate, this has already
happened for navigation requests so there's no need to send them again to the
browser (and it triggers unhandled codepaths if that happens).

This fixes:
org.chromium.content.browser.InterstitialPageTest#testCloseInterstitial
InterstitialPageImplTest.Paste
InterstitialPageImplTest.Cut
DevToolsProtocolTest.InterstitialShownOnAttach
InterstitialPageImplTest.SelectAll
DevToolsProtocolTest.ShowCertificateViewer
InterstitialPageImplTest.Copy
SitePerProcessBrowserTest.NavigateOpenerWithInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkErrorForMaliciousSubresource
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkErrorForMaliciousSubresource
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingMaliciousSubresourceShowsInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkError
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingShowsInterstitialForMalware
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingCanProceedThroughInterstitial
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingShowsInterstitialForMalware
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingMaliciousSubresourceShowsInterstitial
with {--webview-sandboxed-renderer}
org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingBackToSafetyShowsNetworkError
org.chromium.android_webview.test.LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted
org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest#testNotCalledForExistingContentUrl
with {--webview-sandboxed-renderer}

BUG=673806

Review-Url: https://codereview.chromium.org/2729103005
Cr-Commit-Position: refs/heads/master@{#454883}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ff77a6cf88f3a5d793eabb02bd6...
==========

[commit-bot: I haz the power, 2017-03-06 17:47:46]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/4ff77a6cf88f3a5d793eabb02bd6...